Re: Doc: NR Added new Node for Footnotes (issue4751045)

On 2011/07/29 11:35:55, J_lowe wrote: Mike's new addition to footnotes doesn't affect this patch so I would like to get this pushed and when Mike comes back with more explanation for his newer patch which will then take more reviewing I can update the documentation with the additions than h

Re: Doc: NR Added new Node for Footnotes (issue4751045)

Mike's new addition to footnotes doesn't affect this patch so I would like to get this pushed and when Mike comes back with more explanation for his newer patch which will then take more reviewing I can update the documentation with the additions than hold this back. http://codereview.appspot.com

Re: Doc: NR Added new Node for Footnotes (issue4751045)

note from Mike --snip-- I just pushed a patch for automatic footnotes. Everything you need to know about them exists in the two new regtests (233aad0ba9781e43424c4e77a859e42b660210e6). The most important thing to note is that, if people want to use non-automatic footnotes, they must now add fo

Re: Doc: NR Added new Node for Footnotes (issue4751045)

Another draft - I think we're nearly there. On 2011/07/18 21:33:33, Neil Puttock wrote: On 18 July 2011 22:00, wrote: See the documentation for \balloon and \balloonTextGrob. The footnote commands work in exactly the same way. Thanks that helped. \footnoteGr

Re: Doc: NR Added new Node for Footnotes (issue4751045)

On 18 July 2011 22:00, wrote: > Ok I tried > > \relative c' { >  > >> 1 } for myself and it works but I get two indicators and two footnotes > > on each note inside the chord. So is this a special case? If so then I > can add a snippet or another @lilypond to illustrate this. See the documentat

Re: Doc: NR Added new Node for Footnotes (issue4751045)

Thanks for the input, I have some questions about three of the corrections/suggestions. http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/inpu

Re: Doc: NR Added new Node for Footnotes (issue4751045)

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1038 Documentation/notation/input.itely:1038: where the @code{\markup @{in

Re: Doc: NR Added new Node for Footnotes (issue4751045)

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1105 Documentation/notation/input.itely:1105: A way to make them not colli

Re: Doc: NR Added new Node for Footnotes (issue4751045)

http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1024 Documentation/notation/input.itely:1024: for top-level @code{\markup}

Re: Doc: NR Added new Node for Footnotes (issue4751045)

LGTM. Maybe wait a day for Trevor to comment, then push. http://codereview.appspot.com/4751045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR Added new Node for Footnotes (issue4751045)

Third Draft http://codereview.appspot.com/4751045/diff/2001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4751045/diff/2001/Documentation/notation/input.itely#newcode1016 Documentation/notation/input.itely:1016: @funindex \foot

Re: Doc: NR Added new Node for Footnotes (issue4751045)

On 2011/07/16 21:06:34, Graham Percival wrote: you need to do git add Documentation/snippets/new/*.ly git commit Documentation/snippets/new/ to get your new files included in this commit. no wait, sorry, ignore that. My eyes (and the sorting order in rietveld) mislead me. http://codere

Re: Doc: NR Added new Node for Footnotes (issue4751045)

you need to do git add Documentation/snippets/new/*.ly git commit Documentation/snippets/new/ to get your new files included in this commit. http://codereview.appspot.com/4751045/diff/2001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.

Re: Doc: NR Added new Node for Footnotes (issue4751045)

Reviewers: Graham Percival, Message: On 2011/07/16 20:41:43, Graham Percival wrote: could you do a git pull, and then make a new commit for this? I've run makelsr.py locally. Done. Second draft attached. Thanks. Description: Doc: NR Added new Node for Footnotes This is for Trackr issue 15

Doc: NR Added new Node for Footnotes (issue4751045)

could you do a git pull, and then make a new commit for this? I've run makelsr.py locally. http://codereview.appspot.com/4751045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel