Re: Doc: NR 5.5.5 Adv tweaks - Unpure-pure containers (issue 5569050)

2012-01-30 Thread graham
LGTM, although I don't understand any of the pure/unpure stuff. http://codereview.appspot.com/5569050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR 5.5.5 Adv tweaks - Unpure-pure containers (issue 5569050)

2012-01-24 Thread julien . rioux
On 2012/01/24 11:27:42, Graham Percival wrote: If you actually ran "make" and it didn't die, please report this as a build problem, because there's no way that makeinfo should have let this pass. Once issues 2219 is fixed, makeinfo will stop on the first error. Hopefully it considers undefine

Re: Doc: NR 5.5.5 Adv tweaks - Unpure-pure containers (issue 5569050)

2012-01-24 Thread graham
very funny. http://codereview.appspot.com/5569050/diff/4001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/5569050/diff/4001/Documentation/notation/changing-defaults.itely#newcode3721 Documentation/notati

Re: Doc: NR 5.5.5 Adv tweaks - Unpure-pure containers (issue 5569050)

2012-01-23 Thread pkx166h
Reviewers: MikeSol, http://codereview.appspot.com/5569050/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/5569050/diff/1/Documentation/notation/changing-defaults.itely#newcode3714 Documentation/nota

Doc: NR 5.5.5 Adv tweaks - Unpure-pure containers (issue 5569050)

2012-01-23 Thread mtsolo
Looks good! Much more user-understandable than anything I could have ever come up with :) http://codereview.appspot.com/5569050/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/5569050/diff/1/Docume