Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-04 Thread perpeduumimmobile
In short: great work, push it. Two slight remarks on skylines (I prefer the wording in your answer on my post), and perhaps about Hooke's law. But I don't have a strong point on the latter. On 2010/10/02 16:09:22, Mark Polesky wrote: Documentation/notation/spacing.itely:200: @table @code On 20

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-03 Thread Joe Neeman
On Sun, Oct 3, 2010 at 4:36 PM, wrote: > Latest patch set up. Okay to push? > > - Mark > > http://codereview.appspot.com/2316042/ > It's ok with me. ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-03 Thread markpolesky
Latest patch set up. Okay to push? - Mark http://codereview.appspot.com/2316042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-03 Thread Joe Neeman
On Sun, Oct 3, 2010 at 10:59 AM, wrote: > I've uploaded a new patch set for review, but I still have > some questions. > > First, some questions for Joe Neeman: > > Joe, with commit 7d410b9 (from 2009-12-17), in NR 4.4.1 > "Vertical spacing inside a system - Spacing between staves", > you wrote:

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-03 Thread Joe Neeman
On Sun, Oct 3, 2010 at 11:26 AM, Carl Sorensen wrote: > On 10/2/10 10:50 PM, "Joe Neeman" wrote: > > > > On Sat, Oct 2, 2010 at 8:08 PM, wrote: > >> On 2010/10/03 02:49:30, Mark Polesky wrote: > >>> On 2010/10/02 16:32:06, Carl wrote: > >> > >> I don't think so. I think 'padding is added as a

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-03 Thread Carl Sorensen
On 10/2/10 10:50 PM, "Joe Neeman" wrote: > > On Sat, Oct 2, 2010 at 8:08 PM, wrote: >> On 2010/10/03 02:49:30, Mark Polesky wrote: >>> On 2010/10/02 16:32:06, Carl wrote: >> >> I don't think so.  I think 'padding is added as a rigid space interval, >> hence my saying that it is added to the la

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-03 Thread markpolesky
I've uploaded a new patch set for review, but I still have some questions. First, some questions for Joe Neeman: Joe, with commit 7d410b9 (from 2009-12-17), in NR 4.4.1 "Vertical spacing inside a system - Spacing between staves", you wrote: If unset, stretchability defaults to space - minimu

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-03 Thread percival . music . ca
LGTM, although I have no knowledge of the spacing code. http://codereview.appspot.com/2316042/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): http://codereview.appspot.com/2316042/diff/1/Documentation/notation/spacing.itely#newcode198 Documentation

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-03 Thread percival . music . ca
On 2010/10/03 04:50:12, joeneeman wrote: On Sat, Oct 2, 2010 at 8:08 PM, wrote: > I think we should document what we have, and make enhancement requests > for what we would *like* to have. I don't think the exercise of "write > the documents for what we

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-02 Thread Joe Neeman
On Sat, Oct 2, 2010 at 8:08 PM, wrote: > On 2010/10/03 02:49:30, Mark Polesky wrote: > >> On 2010/10/02 16:32:06, Carl wrote: >> > When laying out a page, LilyPond makes a stack of the >> > layout items (staves, lyrics lines, chordnames, etc.) >> > on the page, with a variable spacing item betwee

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-02 Thread Carl . D . Sorensen
On 2010/10/03 02:49:30, Mark Polesky wrote: On 2010/10/02 16:32:06, Carl wrote: > When laying out a page, LilyPond makes a stack of the > layout items (staves, lyrics lines, chordnames, etc.) > on the page, with a variable spacing item between each > pair of layout items. When calculating the de

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-02 Thread markpolesky
On 2010/10/02 16:32:06, Carl wrote: When laying out a page, LilyPond makes a stack of the layout items (staves, lyrics lines, chordnames, etc.) on the page, with a variable spacing item between each pair of layout items. When calculating the desired location of each layout item, the code treats

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-02 Thread Trevor Daniels
markpolesky wrote Saturday, October 02, 2010 5:09 PM Okay, here we go... Hooke's law: F=-kx "x" is the displacement of the end of the spring from its equilibrium position (in SI units: "m"); "F" is the restoring force exerted by the material (in SI units: N or kg·m/s^2); and "k

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-02 Thread Carl . D . Sorensen
On 2010/10/02 16:09:22, Mark Polesky wrote: On 2010/10/02 09:17:16, perpeduumimmobile wrote: > Again, it's a reference. We can mentioned Hooke's > law, don't we? Okay, here we go... Hooke's law: F=-kx "x" is the displacement of the end of the spring from its equilibrium posit

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-02 Thread markpolesky
http://codereview.appspot.com/2316042/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): http://codereview.appspot.com/2316042/diff/1/Documentation/notation/spacing.itely#newcode200 Documentation/notation/spacing.itely:200: @table @code On 2010/10/02 0

Re: Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-02 Thread tdanielsmusic
Looks a lot clearer to me, Mark, but I can't vouch for the accuracy as I've never tried to use vertical spacing. If the variable table came before the keys table giving a top-down approach it would be even clearer. Trevor http://codereview.appspot.com/2316042/ _

Doc: NR 4.1.2: Reorganize vertical dimensions. (issue2316042)

2010-10-01 Thread markpolesky
Reviewers: , Message: The vertical dimensions docs in NR 4.1.2 "Page formatting" are (in my opinion) incredibly confusing. Here's a patch to reorganize that section. One big disclaimer: the information here is presented according to *my* understanding of how these variables were *intended* to b