On 2010/11/21 08:55:01, Trevor Daniels wrote:
Looks good to go to me
Trevor
Patch pushed and issue closed. Thanks to everyone who helped out.
This is a big change and I'm glad to see it finished!
- Mark
http://codereview.appspot.com/2758042/
__
Looks good to go to me
Trevor
http://codereview.appspot.com/2758042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Patch set 7. We're down to nitpicks here...
I can't really think of a good way to break this up, except
into 2 commits, the 2nd being far larger than the first.
1) Organize paper-defaults-init.ly.
2) Doc: NR 4.1, 4.2: Reorganize, clarify details.
On 2010/11/20 19:34:44, Mark Polesky wrote:
CG says: NR, Installed Files, Snippets, IR.
Is that wrong?
Hhm. Seems like I mis-remembered where Installed Files goes. I'd argue
it's wrong though, if the order is based on easiest to hardest, or on
recommended order of reference - that's why I tho
This last patch set (#6) assumes this patch:
http://codereview.appspot.com/3199041/
I'm leaving most of the @item stuff as is.
We can always debate it more, but it doesn't
need to hold up this patch.
- Mark
http://codereview.appspot.com/2758042/diff/35001/Documentation/notation/spacing.itely
F
Content looks fine. A few typographical comments.
http://codereview.appspot.com/2758042/diff/35001/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (left):
http://codereview.appspot.com/2758042/diff/35001/Documentation/notation/spacing.itely#oldcode793
Documentati
http://codereview.appspot.com/2758042/diff/35001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/2758042/diff/35001/Documentation/notation/input.itely#newcode774
Documentation/notation/input.itely:774: @code{make-footer} and
@code
On 2010/11/18 09:18:27, Mark Polesky wrote:
However, I'd like to point out that I tried to organize
paper-defaults-init.ly a little bit, and I need to know if I
recklessly broke anything there by changing the order of the
declarations. Can someone confirm that it's fine?
Have you done a regtes
LGTM. THanks, Mark.
Carl
http://codereview.appspot.com/2758042/diff/35001/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/2758042/diff/35001/Documentation/notation/spacing.itely#newcode112
Documentation/notation/spacing.it
Hi guys,
Patch set 5 finally makes the changes that Carl requested
from the beginning: it's better to refer to a file where
default values are defined, than to list them in the
property descriptions. I've now done this, and I think this
thing is ready to commit.
However, I'd like to point out t
Looks ok.
http://codereview.appspot.com/2758042/diff/23001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/2758042/diff/23001/Documentation/notation/input.itely#newcode759
Documentation/notation/input.itely:759: @snippets
Err, th
LGTM
Trevor
http://codereview.appspot.com/2758042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Patch set 4 uploaded.
- Mark
http://codereview.appspot.com/2758042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
It looks better. I added a couple of minor comments which I noticed in
passing, but I've not checked any of the detail.
Trevor
http://codereview.appspot.com/2758042/diff/19002/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com
Guys, I totally reorganized things yet again, and added a
lot of useful info. I am aware that many of your previous
comments have not been addressed yet (I'm not ignoring
them). But I'd like to know what you guys think of the new
text and organization. This is still a work in progress
Than
Mark, I wanted to flag a bit of cleanup, and this reasonably-related
patch still shows as 'open'.
http://codereview.appspot.com/2758042/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/2758042/diff/1/Documentation/notat
http://codereview.appspot.com/2758042/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/2758042/diff/1/Documentation/notation/spacing.itely#newcode209
Documentation/notation/spacing.itely:209: by setting @code{paper-heigh
http://codereview.appspot.com/2758042/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/2758042/diff/1/Documentation/notation/spacing.itely#newcode428
Documentation/notation/spacing.itely:428: @c TODO: Where do
headers/fo
Mark,
What a lot of work! Thanks for taking this on!
I think that this is a big improvement, because of its thoroughness.
I think that your subheadings need to become nodes (subsubsections?).
I think that it would be nice if the defaults are easily accessible in a
file somewhere to point us t
Reviewers: ,
Message:
Okay guys, here's my first draft patch for a rewrite of
NR 4.1 Paper and Pages.
Just to clarify, this is totally unrelated to my rewrite of
NR 4.4.1 Vertical spacing inside a system
(http://codereview.appspot.com/2642043/)
So, I guess this is a big patch. Sorry about that
20 matches
Mail list logo
