Re: Doc: Learning: Use voices in the intended order. (issue 5507050)

2012-03-13 Thread Trevor Daniels
Keith, you wrote Tuesday, March 13, 2012 5:53 AM Subject: Re: Doc: Learning: Use voices in the intended order. (issue 5507050) On 2012/03/10 12:36:05, Trevor Daniels wrote: I could see no reason for this patch causing problems I had mis-spelled the option to ignore-collisions, which

Re: Doc: Learning: Use voices in the intended order. (issue 5507050)

2012-03-12 Thread k-ohara5a5a
Reviewers: carl.d.sorensen_gmail.com, Graham Percival, Trevor Daniels, Message: On 2012/03/10 12:36:05, Trevor Daniels wrote: I could see no reason for this patch causing problems I had mis-spelled the option to ignore-collisions, which threw a warning, but I didn't catch it because other over

Re: Doc: Learning: Use voices in the intended order. (issue 5507050)

2012-03-10 Thread tdanielsmusic
The second part of this patch has now been pushed to staging, so (assuming they make it to master) this issue can be closed. http://codereview.appspot.com/5507050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/lis

Re: Doc: Learning: Use voices in the intended order. (issue 5507050)

2012-03-10 Thread tdanielsmusic
I could see no reason for this patch causing problems with make or make doc - both ran clean here. So I split this into the two unrelated patches to Learning and Notation, corrected the patch to Learning and pushed to staging. I'll check the patch to Notation next. http://codereview.appspot.com

Re: Doc: Learning: Use voices in the intended order. (issue 5507050)

2012-01-06 Thread graham
On 2012/01/07 02:41:11, Graham Percival wrote: this commit appears to break staging. hmm, I'm seeing an error somewhere else even after removing this. It's just possible that there's some random breakage that coincidentally just happened to occur in this location. If that's the case, I apolog

Re: Doc: Learning: Use voices in the intended order. (issue 5507050)

2012-01-06 Thread graham
this commit appears to break staging. http://codereview.appspot.com/5507050/diff/6001/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): http://codereview.appspot.com/5507050/diff/6001/Documentation/learning/tweaks.itely#newcode2899 Documentation/learning/twea

Doc: Learning: Use voices in the intended order. (issue 5507050)

2012-01-02 Thread Carl . D . Sorensen
LGTM http://codereview.appspot.com/5507050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel