Re: Deletes logfiles in build dir with make clean (issue 6300079)

2012-06-16 Thread graham
LGTM, and if you want to push it right now instead of waiting for the countdown to officially end I think that's entirely fine. http://codereview.appspot.com/6300079/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/

Re: Deletes logfiles in build dir with make clean (issue 6300079)

2012-06-14 Thread john . mandereau
LGTM http://codereview.appspot.com/6300079/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Deletes logfiles in build dir with make clean (issue 6300079)

2012-06-13 Thread PhilEHolmes
Please review http://codereview.appspot.com/6300079/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Deletes logfiles in build dir with make clean (issue 6300079)

2012-06-12 Thread john . mandereau
I'm not certain cleaning the build tree should include log files cleaning, when a simple "find -name '*.log' |xargs rm -f" does the job. However, if this is a very popular request, then you may want to read a few comments. http://codereview.appspot.com/6300079/diff/1/GNUmakefile.in File GNUmake

Re: Deletes logfiles in build dir with make clean (issue 6300079)

2012-06-11 Thread graham
LGTM http://codereview.appspot.com/6300079/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Deletes logfiles in build dir with make clean (issue 6300079)

2012-06-11 Thread PhilEHolmes
Reviewers: Julien Rioux, Graham Percival, Message: Please review. Description: Fixes issue 2415 by deleting all the logfiles created during make, make doc or make test. The deletion is non-selective - running make clean, make doc clean or make test clean will delete all the logfiles created in