Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-23 Thread ColinPKCampbell
Pushed as 5f81429c8f8263eef85b4f7881d243cb9722e971 Details of how to push will be in a seperate patch. http://codereview.appspot.com/4898058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-22 Thread Reinhold Kainhofer
Am Monday, 22. August 2011, 09:49:41 schrieben Sie: > Yes, definitely do the pushing stuff in a separate patch. But here's an > outline: > 1. update with >git pull -r > 2. check you only have 1 patch ready with >git status That's the step where I like qgit, because it gives you a really g

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-22 Thread Janek Warchoł
2011/8/22 : > Yes, definitely do the pushing stuff in a separate patch.  But here's an > outline: > 1. update with >  git pull -r > 2. check you only have 1 patch ready with >  git status git status shows patches?? Didn't you mean "check that your work is nicely packed in one commit using git log

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-22 Thread percival . music . ca
Yes, definitely do the pushing stuff in a separate patch. But here's an outline: 1. update with git pull -r 2. check you only have 1 patch ready with git status 3. upload your changes with git push http://codereview.appspot.com/4898058/ ___ lil

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-21 Thread ColinPKCampbell
Regarding the addition of instructions on how to push, I'd like to do that in a separate patch, unless an experienced developer cares to send me a rough sketch, point form perhaps, which I could then repackage in documentation format. http://codereview.appspot.com/4898058/ __

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-21 Thread janek . lilypond
On 2011/08/18 11:42:06, Reinhold wrote: On 2011/08/18 11:21:22, PhilEHolmes wrote: > LGTM too. My suggestion would be to add some instructions about actually > pushing. It took me a while to convince myself that all that appears to be > needed is to have an unpushed commit and type "git pus

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-21 Thread Reinhold Kainhofer
Am Friday, 19. August 2011, 05:11:30 schrieben Sie: > On Fri, Aug 19, 2011 at 03:21:03AM +0200, Reinhold Kainhofer wrote: > > Am Friday 19 August 2011, 02:29:22 schrieb percival.music...@gmail.com: > > > On 2011/08/18 11:42:13, Reinhold wrote: > > > > Why did you change all dsa to rsa? > > > > It'

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-18 Thread ColinPKCampbell
Reviewers: Graham Percival, phileholmes_googlemail.com, Reinhold, reinhold_kainhofer.com, graham_percival-music.ca, Message: On 2011/08/19 03:11:15, graham_percival-music.ca wrote: On Fri, Aug 19, 2011 at 03:21:03AM +0200, Reinhold Kainhofer wrote: > Am Friday 19 August 2011, 02:29:22 schrieb

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-18 Thread Graham Percival
On Fri, Aug 19, 2011 at 03:21:03AM +0200, Reinhold Kainhofer wrote: > Am Friday 19 August 2011, 02:29:22 schrieb percival.music...@gmail.com: > > On 2011/08/18 11:42:13, Reinhold wrote: > > > Why did you change all dsa to rsa? > It's not only savannah, it's basically everone who knows a little bit

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-18 Thread Reinhold Kainhofer
Am Friday 19 August 2011, 02:29:22 schrieb percival.music...@gmail.com: > On 2011/08/18 11:42:13, Reinhold wrote: > > Why did you change all dsa to rsa? > > Really?! this whole topic began because somebody said that savannah > requested that people use dsa because it was more secure. It's not on

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-18 Thread percival . music . ca
On 2011/08/18 11:42:13, Reinhold wrote: Documentation/contributor/source-code.itexi:1425: Generate an SSH @q{rsa} key pair. Enter the following at the Why did you change all dsa to rsa? RSA is the older encryption technology, which is known not to be as secure as DSA... Really?! this whol

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-18 Thread reinhold . kainhofer
http://codereview.appspot.com/4898058/diff/1/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right): http://codereview.appspot.com/4898058/diff/1/Documentation/contributor/source-code.itexi#newcode1425 Documentation/contributor/source-code.itexi:1425

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-18 Thread reinhold . kainhofer
On 2011/08/18 11:21:22, PhilEHolmes wrote: LGTM too. My suggestion would be to add some instructions about actually pushing. It took me a while to convince myself that all that appears to be needed is to have an unpushed commit and type "git push". Yes, it' s really that simple ;-) We sho

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-18 Thread PhilEHolmes
LGTM too. My suggestion would be to add some instructions about actually pushing. It took me a while to convince myself that all that appears to be needed is to have an unpushed commit and type "git push". http://codereview.appspot.com/4898058/ ___

DOC: Revise CG 3.4 Commit Access (issue 4898058)

2011-08-17 Thread percival . music . ca
LGTM, one suggestion. http://codereview.appspot.com/4898058/diff/1/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right): http://codereview.appspot.com/4898058/diff/1/Documentation/contributor/source-code.itexi#newcode1574 Documentation/contributor