LGTM
please push after regtests come out clean
http://codereview.appspot.com/4752048/diff/4001/lily/stem.cc
File lily/stem.cc (right):
http://codereview.appspot.com/4752048/diff/4001/lily/stem.cc#newcode754
lily/stem.cc:754: */
this comment looks outdated. I think the work of ledger is done in
My "review" will be a bit non-standard (as i'm still a rookie
programmer): i understand what's going on here, so it's probably good :)
http://codereview.appspot.com/4752048/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/m
On 2011/07/18 00:53:01, hanwenn wrote:
LGTM
There is some code that adjusts for the shape of the notehead as well
(look for
calls to
Note_head::stem_attachment_coordinate). Can you have a look if you can
work that
into your code too?
Done. New patch set uploaded.
http://codereview.apps
LGTM
There is some code that adjusts for the shape of the notehead as well
(look for calls to
Note_head::stem_attachment_coordinate). Can you have a look if you can
work that into your code too?
http://codereview.appspot.com/4752048/
___
lilypond-deve
Reviewers: ,
Message:
On Jul 1, 2011, at 5:50 PM, Han-Wen Nienhuys wrote:
On Thu, Jun 30, 2011 at 12:46 PM, m...@apollinemike.com
wrote:
can you show png examples of what you're trying to do?
Honestly, I cannot allow this patch in its current design. I don't see
a reason for an obscure feat
