Re: Compilation fixes for GUILE 2.2 (issue 571430046 by hanw...@gmail.com)

2020-01-26 Thread jonas . hahnfeld
On 2020/01/26 14:37:44, dak wrote: > https://codereview.appspot.com/571430046/diff/551390052/lily/main.cc > File lily/main.cc (right): > > https://codereview.appspot.com/571430046/diff/551390052/lily/main.cc#newcode830 > lily/main.cc:830: catch (std::exception e) > On 2020/01/26 14:24:02, hahnjo w

Re: Compilation fixes for GUILE 2.2 (issue 571430046 by hanw...@gmail.com)

2020-01-26 Thread dak
https://codereview.appspot.com/571430046/diff/551390052/lily/main.cc File lily/main.cc (right): https://codereview.appspot.com/571430046/diff/551390052/lily/main.cc#newcode830 lily/main.cc:830: catch (std::exception e) On 2020/01/26 14:24:02, hahnjo wrote: > On 2020/01/26 14:18:20, hanwenn wrote

Re: Compilation fixes for GUILE 2.2 (issue 571430046 by hanw...@gmail.com)

2020-01-26 Thread nine . fierce . ballads
https://codereview.appspot.com/571430046/diff/551390052/lily/main.cc File lily/main.cc (right): https://codereview.appspot.com/571430046/diff/551390052/lily/main.cc#newcode830 lily/main.cc:830: catch (std::exception e) My time is short this morning, so I can't digest this whole situation, but if

Re: Compilation fixes for GUILE 2.2 (issue 571430046 by hanw...@gmail.com)

2020-01-26 Thread jonas . hahnfeld
https://codereview.appspot.com/571430046/diff/551390052/lily/main.cc File lily/main.cc (right): https://codereview.appspot.com/571430046/diff/551390052/lily/main.cc#newcode830 lily/main.cc:830: catch (std::exception e) On 2020/01/26 14:18:20, hanwenn wrote: > On 2020/01/26 14:13:58, hahnjo wrote

Re: Compilation fixes for GUILE 2.2 (issue 571430046 by hanw...@gmail.com)

2020-01-26 Thread hanwenn
Reviewers: hahnjo, https://codereview.appspot.com/571430046/diff/551390052/lily/main.cc File lily/main.cc (right): https://codereview.appspot.com/571430046/diff/551390052/lily/main.cc#newcode830 lily/main.cc:830: catch (std::exception e) On 2020/01/26 14:13:58, hahnjo wrote: > Is it really throw

Compilation fixes for GUILE 2.2 (issue 571430046 by hanw...@gmail.com)

2020-01-26 Thread jonas . hahnfeld
https://codereview.appspot.com/571430046/diff/551390052/lily/main.cc File lily/main.cc (right): https://codereview.appspot.com/571430046/diff/551390052/lily/main.cc#newcode830 lily/main.cc:830: catch (std::exception e) Is it really throwing C++ exceptions? If this means to catch any from LilyPon