Re: Coding style of create-version-itexi.py

2009-12-27 Thread Graham Percival
2009/12/28 John Mandereau : > Le dimanche 27 décembre 2009 à 23:56 +, Graham Percival a écrit : >> > - duplicate definition of depth looks like a maintenance nightmare >> > similar to the issue Joe just reported on -devel; >> >> That's not an issue; AFAIK the macros won't be used in a normal do

Re: Coding style of create-version-itexi.py

2009-12-27 Thread John Mandereau
Le dimanche 27 décembre 2009 à 23:56 +, Graham Percival a écrit : > Done. Thank you. > > - duplicate definition of depth looks like a maintenance nightmare > > similar to the issue Joe just reported on -devel; > > That's not an issue; AFAIK the macros won't be used in a normal doc > build.

Re: Coding style of create-version-itexi.py

2009-12-27 Thread Graham Percival
2009/12/27 John Mandereau : > - every tab should be replaced with 4-spaces; > - "line[0:x] ==" should be replaced with more easy-to-write > "line.startswith"; > - uncleaned commented code that according to the comment doesn't work > with Python 2.4.5. Done. > - duplicate definition of depth looks

Coding style of create-version-itexi.py

2009-12-27 Thread John Mandereau
Hi Graham, scripts/build/create-version-itexi.py has a couple of coding style nitpicks that should be fixed: - every tab should be replaced with 4-spaces; - duplicate definition of depth looks like a maintenance nightmare similar to the issue Joe just reported on -devel; - "line[0:x] ==" should b