Re: Cleaning Feta flags code (issue4236043)

2011-03-08 Thread Janek Warchoł
Here you are. 2011/3/8 > Hearing no objections to the contrary, let's move forward. Janek, could > you send me a patch for pushing? > > > http://codereview.appspot.com/4236043/ > From 36fc7746295b387e297ce0e4999a166eac836307 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Janek=20Warcho=C5=82?= Date:

Re: Cleaning Feta flags code (issue4236043)

2011-03-08 Thread percival . music . ca
Hearing no objections to the contrary, let's move forward. Janek, could you send me a patch for pushing? http://codereview.appspot.com/4236043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Cleaning Feta flags code (issue4236043)

2011-03-03 Thread percival . music . ca
LGTM, passes regtests. I'm not familiar with how we indent our mf files, so I can't vouch for that. http://codereview.appspot.com/4236043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Cleaning Feta flags code (issue4236043)

2011-03-02 Thread lemniskata . bernoullego
Indents fixed. Sorry it took so long - i had limited access to my lilydev-enabled machine. http://codereview.appspot.com/4236043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Cleaning Feta flags code (issue4236043)

2011-02-25 Thread hanwenn
LGTM please fix all indents http://codereview.appspot.com/4236043/diff/1/mf/feta-flags.mf File mf/feta-flags.mf (right): http://codereview.appspot.com/4236043/diff/1/mf/feta-flags.mf#newcode138 mf/feta-flags.mf:138: save flagspace, total_depth, flag_count; can you fix indent? http://coderevie

Re: Cleaning Feta flags code (issue4236043)

2011-02-25 Thread Janek Warchoł
2011/2/25 : > I have created new [PATCH] issue for this: > http://code.google.com/p/lilypond/issues/detail?id=1541 Thanks! ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Cleaning Feta flags code (issue4236043)

2011-02-25 Thread neziap
I have created new [PATCH] issue for this: http://code.google.com/p/lilypond/issues/detail?id=1541 http://codereview.appspot.com/4236043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Cleaning Feta flags code (issue4236043)

2011-02-25 Thread lemniskata . bernoullego
This is a preparation for changes in the flag code that will be made later (shortened flags affair). This patch makes flags code more uniform and easier to maintain. There is no actual change to the font itself, only to the way it is coded. (You may check this by running mf '\mode:=proof; input