On 2011/12/21 02:56:37, md5i wrote:
http://codereview.appspot.com/5489092/diff/1/lily/parser.yy
File lily/parser.yy (right):
http://codereview.appspot.com/5489092/diff/1/lily/parser.yy#newcode36
lily/parser.yy:36: /* Define to get rid of conversion warning, int ->
int16_t.
I'd love to see a
http://codereview.appspot.com/5489092/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/12/20 16:27:08, Graham Percival wrote:
On Tue, Dec 20, 2011 at 02:52:34AM +, mailto:md5i.m...@gmail.com
wrote:
>
> In point of fact, I found no additional errors when running make
check.
> Please understand, though, that I have a 32-bit machine. Other
warnings
> may pup up with
On 2011/12/20 14:02:50, Reinhold wrote:
Is anyone here using a 64-bit OS? There are ~150 compiler warnings
when
compiling lilypond currently (see bug 1890), so -Werror can't be
enabled on
64-bit systems.
Yes, this does not surprise me. I wish I had a 64-bit system, but I'm
not due for an u
http://codereview.appspot.com/5489092/diff/1/lily/parser.yy
File lily/parser.yy (right):
http://codereview.appspot.com/5489092/diff/1/lily/parser.yy#newcode36
lily/parser.yy:36: /* Define to get rid of conversion warning, int ->
int16_t. This has
On 2011/12/20 08:32:27, dak wrote:
I think the
On Tue, Dec 20, 2011 at 02:52:34AM +, md5i.m...@gmail.com wrote:
>
> In point of fact, I found no additional errors when running make check.
> Please understand, though, that I have a 32-bit machine. Other warnings
> may pup up with a 64-bit compile.
hmm, was this with
-Wextra -Wconversion
Reviewers: ,
Message:
A set of changes to allow lilypond to be built with -Werror using gcc
4.6.2 on i386. I don't know if these changes are desirable, but I am
submitting them in the hopes that they may be useful.
Description:
Changes to allow compiling with -Werror using gcc 4.6.2 on i386.
P
- Original Message -
From:
To: ; ;
; ;
Cc: ;
Sent: Tuesday, December 20, 2011 2:02 PM
Subject: Re: Changes to allow compiling with -Werror using gcc 4.6.2 on
i386.(issue 5489092)
Is anyone here using a 64-bit OS? There are ~150 compiler warnings when
compiling lilypond currently
On 11-12-20 07:02 AM, reinhold.kainho...@gmail.com wrote:
Is anyone here using a 64-bit OS? There are ~150 compiler warnings when
compiling lilypond currently (see bug 1890), so -Werror can't be enabled
on 64-bit systems.
http://codereview.appspot.com/5489092/
_
Is anyone here using a 64-bit OS? There are ~150 compiler warnings when
compiling lilypond currently (see bug 1890), so -Werror can't be enabled
on 64-bit systems.
http://codereview.appspot.com/5489092/
___
lilypond-devel mailing list
lilypond-devel@g
http://codereview.appspot.com/5489092/diff/1/lily/parser.yy
File lily/parser.yy (right):
http://codereview.appspot.com/5489092/diff/1/lily/parser.yy#newcode36
lily/parser.yy:36: /* Define to get rid of conversion warning, int ->
int16_t. This has
I think the side effect of significantly increas
On 2011/12/20 03:55:59, Carl wrote:
Personally, I see no reason to use I64 instead of int. Neil Puttock
changed the
numerator and denominators to be I64 in 2008, with commit
be65b81068e99ed855334f332c3176d8b4942a11
I don't think that research on the history of such changes should be
holding
This patch will collide with the outstanding patch fixing beaming, as
the variables have changed and are treated as int.
Personally, I see no reason to use I64 instead of int. Neil Puttock
changed the numerator and denominators to be I64 in 2008, with commit
be65b81068e99ed855334f332c3176d8b4942
http://codereview.appspot.com/5489092/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/12/20 01:54:29, Graham Percival wrote:
You'll probably find a ton of more errors when running 'make check' --
apparently that compiles some stuff in flower/ that isn't compiled
during a
normal make.
In point of fact, I found no additional errors when running make check.
Please unders
http://codereview.appspot.com/5489092/diff/1/lily/beaming-pattern.cc
File lily/beaming-pattern.cc (right):
http://codereview.appspot.com/5489092/diff/1/lily/beaming-pattern.cc#newcode187
lily/beaming-pattern.cc:187: I64 count = 1; //default -- 1 base moments
in a beam
On 2011/12/20 01:54:29, Gr
wow, I'd love to enable -Werror!
You'll probably find a ton of more errors when running 'make check' --
apparently that compiles some stuff in flower/ that isn't compiled
during a normal make.
http://codereview.appspot.com/5489092/diff/1/lily/beaming-pattern.cc
File lily/beaming-pattern.cc (rig
17 matches
Mail list logo