Re: Changes how mensural flags are drawn (issue 13122044)

2013-08-22 Thread lemzwerg
LGTM, thanks. In case you have time, you might replace { foo } z1 { bar } with {foo}z1{bar} for consistency with other files, but this is not really important. https://codereview.appspot.com/13122044/ ___ lilypond-devel mailing list lilypond-

Re: Changes how mensural flags are drawn (issue 13122044)

2013-08-22 Thread PhilEHolmes
Please review. https://codereview.appspot.com/13122044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Changes how mensural flags are drawn (issue 13122044)

2013-08-20 Thread Phil Holmes
- Original Message - From: To: ; ; Cc: ; Sent: Tuesday, August 20, 2013 6:10 PM Subject: Re: Changes how mensural flags are drawn (issue 13122044) Well, in other MF source files the `fill' operator's arguments are aligned vertically also: fill z1 .. z2

Re: Changes how mensural flags are drawn (issue 13122044)

2013-08-20 Thread lemzwerg
Well, in other MF source files the `fill' operator's arguments are aligned vertically also: fill z1 .. z2 .. z3 The alignment consists of zero or more tabs plus the necessary spaces. https://codereview.appspot.com/13122044/ ___ lilypo

Re: Changes how mensural flags are drawn (issue 13122044)

2013-08-20 Thread Phil Holmes
- Original Message - From: To: ; Cc: ; Sent: Tuesday, August 20, 2013 5:40 PM Subject: Re: Changes how mensural flags are drawn (issue 13122044) LGTM, except indentation: In MF files, we use real tabs. https://codereview.appspot.com/13122044/ Aaargh. Thought I'd got that

Re: Changes how mensural flags are drawn (issue 13122044)

2013-08-20 Thread lemzwerg
LGTM, except indentation: In MF files, we use real tabs. https://codereview.appspot.com/13122044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Changes how mensural flags are drawn (issue 13122044)

2013-08-20 Thread janek . lilypond
code LGTM, and i like the new shapes. https://codereview.appspot.com/13122044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Changes how mensural flags are drawn (issue 13122044)

2013-08-20 Thread PhilEHolmes
Reviewers: lemzwerg, Message: Please review. Description: Issue 3105 complains that mensural flags do not attach to stems very well. This patch makes them attach in the same way as modern flags, and changes how they're drawn - I think the way this is now done is more metafont-y. It also gets t