For the Doc/Notation/fretted-strings.itely - that looks good.
I can't comment on the rest.
http://codereview.appspot.com/3842041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
I've responded to all the commandments and put up a new patch.
Thanks for all of your input.
Please review.
Carl
http://codereview.appspot.com/3842041/diff/6001/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
http://codereview.appspot.
On 2010/12/29 05:18:07, Keith wrote:
ly/string-tunings-init.ly:43: (make-music 'SequentialMusic 'void #t)))
> We need to save the string tuning in a Scheme variable...
But if it is possible to set the variable as you do now, and then
return a
PropertySet instead of the void event,
(begin
(c
On 2010/12/29 05:18:07, Keith wrote:
Agreed. My earlier 'arbitrary' was a mental slip. I was thinking the
choice was
sensible, but even if it were arbitrary I would be scared of change.
> The order for the chord entry was requested by the users. Chords
are
generally
> entered lowest note
er 2010 18:25
> To: carl.d.soren...@gmail.com; lilypond-devel@gnu.org;
> re...@codereview.appspotmail.com
> Cc: k-ohara5...@oco.net
> Subject: Re: Change stringTunings entries from semitones to pitches
> (issue3842041)
>
> Am 29.12.2010 19:22, schrieb Marc Hohl:
> > [..
James Lowe writes:
> Am 29.12.2010 19:22, schrieb Marc Hohl:
>> [...]
>> But for duitar,
> I meant "guitar", of course - don't know how a "duitar" is tuned and
> played ;-)
>
> With gifficulty I expect!
Good thing that the Unisys gif patents expired already, so support in
Lilypond should not be
...@codereview.appspotmail.com
Cc: k-ohara5...@oco.net
Subject: Re: Change stringTunings entries from semitones to pitches
(issue3842041)
Am 29.12.2010 19:22, schrieb Marc Hohl:
> [...]
> But for duitar,
I meant "guitar", of course - don't know how a "duitar" is tuned and
pla
Am 29.12.2010 19:22, schrieb Marc Hohl:
[...]
But for duitar,
I meant "guitar", of course - don't know how a "duitar" is tuned and
played ;-)
Marc
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond
Am 29.12.2010 06:18, schrieb k-ohara5...@oco.net:
[...]
The order for the chord entry was requested by the users. Chords are
generally
entered lowest note first.
Yes, but were the users right? I would have asked for that order of
entry, too, but would have changed my mind for fear of bugs
Just a couple of Doc-policy things
http://codereview.appspot.com/3842041/diff/6001/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
http://codereview.appspot.com/3842041/diff/6001/Documentation/notation/fretted-strings.itely#newcode484
Docu
Everything I know how to check looks good.
http://codereview.appspot.com/3842041/diff/6001/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
http://codereview.appspot.com/3842041/diff/6001/Documentation/notation/fretted-strings.itely#newcode
Thanks again for the review. Here are my responses to your comments.
Thanks,
Carl
http://codereview.appspot.com/3842041/diff/6001/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
http://codereview.appspot.com/3842041/diff/6001/Documenta
On 2010/12/29 02:25:44, Keith wrote:
I'm not a programmer, but accustomed to doing code review as a systems
engineer.
I very much appreciate the review. Thanks!
> Change stringTunings entries from semitones to pitches
> This lays the foundation for creating a TabKey grob
Presumably the
I'm not a programmer, but accustomed to doing code review as a systems
engineer.
Change stringTunings entries from semitones to pitches
This lays the foundation for creating a TabKey grob
Presumably the idea is to store the correct spelling of the note in the
future TabKey, should anyone tune
Reviewers: ,
Message:
Here's a patch that changes stringTunings entries from semitones to
pitches.
This is needed to allow a TabKey grob to be created.
Also defines stringTunings for orchestral strings, and includes a
function to allow the definition of stringTunings using absolute mode
chords.
15 matches
Mail list logo
