Re: CG: out-of-tree building in main compile chapter. (issue3823045)

2011-01-04 Thread percival . music . ca
thanks, pushed. http://codereview.appspot.com/3823045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG: out-of-tree building in main compile chapter. (issue3823045)

2011-01-04 Thread John Mandereau
Il giorno mar, 04/01/2011 alle 10.35 +, Graham Percival ha scritto: > On Tue, Jan 04, 2011 at 09:58:46AM +, john.mander...@gmail.com wrote: > > LGTM, apart a nitpick: I prefer to create build directory outside git > > tree, i.e. if foo/lily is my git repo, I build in foo/build, to avoid > >

Re: CG: out-of-tree building in main compile chapter. (issue3823045)

2011-01-04 Thread Graham Percival
On Tue, Jan 04, 2011 at 09:58:46AM +, john.mander...@gmail.com wrote: > LGTM, apart a nitpick: I prefer to create build directory outside git > tree, i.e. if foo/lily is my git repo, I build in foo/build, to avoid > build/ appear to git as an untracked file. Check .gitignore. :) I personally

Re: CG: out-of-tree building in main compile chapter. (issue3823045)

2011-01-04 Thread john . mandereau
On 2011/01/01 00:47:54, Graham Percival wrote: Please review. LGTM, apart a nitpick: I prefer to create build directory outside git tree, i.e. if foo/lily is my git repo, I build in foo/build, to avoid build/ appear to git as an untracked file. http://codereview.appspot.com/3823045/ _

Re: CG: out-of-tree building in main compile chapter. (issue3823045)

2011-01-04 Thread tdanielsmusic
I've not tried following it, but it looks clear enough to me. http://codereview.appspot.com/3823045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG: out-of-tree building in main compile chapter. (issue3823045)

2011-01-03 Thread percival . music . ca
No complaints? I'll go ahead and push it in 24 hours if nobody objects or asks for more time. (you don't need to have any specific objections; if you're busy and can't review it for the next few days, but want to review it, just let me know and I'll wait) http://codereview.appspot.com/3823045/

CG: out-of-tree building in main compile chapter. (issue3823045)

2010-12-31 Thread percival . music . ca
Reviewers: , Message: Please review. Description: CG: out-of-tree building in main compile chapter. Please review this at http://codereview.appspot.com/3823045/ Affected files: M Documentation/included/compile.itexi Index: Documentation/included/compile.itexi diff --git a/Documentation/inc