Re: Build: un-nodify markup-*-commands.tely (issue2140041)

2010-09-03 Thread Carl Sorensen
LGTM. Carl On 9/3/10 12:01 PM, "percival.music...@gmail.com" wrote: > On 2010/09/03 17:41:37, Carl wrote: >> scm/documentation-generate.scm:56: ;; magic number to remove the > initial part >> Can we have something in the comment that says what would have to > change in >> order to change the m

Re: Build: un-nodify markup-*-commands.tely (issue2140041)

2010-09-03 Thread percival . music . ca
On 2010/09/03 17:41:37, Carl wrote: scm/documentation-generate.scm:56: ;; magic number to remove the initial part Can we have something in the comment that says what would have to change in order to change the magic number? Thanks for the comment; done. I should have done this math to begi

Re: Build: un-nodify markup-*-commands.tely (issue2140041)

2010-09-03 Thread Carl . D . Sorensen
Looks acceptable to me, with one slight change if it's possible. THanks, Carl http://codereview.appspot.com/2140041/diff/2001/3006 File scm/documentation-generate.scm (right): http://codereview.appspot.com/2140041/diff/2001/3006#newcode56 scm/documentation-generate.scm:56: ;; magic number to

Build: un-nodify markup-*-commands.tely (issue2140041)

2010-09-03 Thread percival . music . ca
Reviewers: , Message: This isn't a miracle of clean scheme, but I don't think it's completely horrible, gets the job done, and makes the doc-editor's lives easier. Description: Build: un-nodify markup-*-commands.tely Please review this at http://codereview.appspot.com/2140041/ Affected files: