No complaints, and I just double-checked that the regtest is ok. Please
push.
http://codereview.appspot.com/212048/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM.
Carl
http://codereview.appspot.com/212048/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/01/22 20:29:17, Graham Percival wrote:
Patch looks great, passes regtests, and I built the docs from scratch
with it.
I think it's ready to be pushed.
Thanks. I've deliberately left out doc changes (i.e., snippets, removal
of known issue and changes entry), but they'd follow soon af
On 2011/01/22 20:25:03, Graham Percival wrote:
Looks excellent, but -- what's a double slash? :)
Sorry, ignore this; I just checked Notation 1.4.2 Repeats. Oops.
Patch looks great, passes regtests, and I built the docs from scratch
with it. I think it's ready to be pushed.
http://coderevi
Looks excellent, but -- what's a double slash? :)
http://codereview.appspot.com/212048/diff/64001/lily/percent-repeat-iterator.cc
File lily/percent-repeat-iterator.cc (right):
http://codereview.appspot.com/212048/diff/64001/lily/percent-repeat-iterator.cc#newcode58
lily/percent-repeat-iterator
Reviewers: ,
Message:
Hi everybody,
You might remember this patch from a while ago. :)
I've dusted it off and made several improvements.
Please review.
Thanks,
Neil
Description:
Better support for beat slashes (multi-slash & mixed duration).
* lily/context.cc:
add repeat count visibility
