Re: Better pure height approximations for beamed rests. (issue 4860043)

2012-04-27 Thread m...@apollinemike.com
On 27 avr. 2012, at 23:55, Keith OHara wrote: > On Fri, 27 Apr 2012 12:01:04 -0700, m...@apollinemike.com > wrote: > >> On 27 avr. 2012, at 19:58, Keith OHara wrote: On Thu, 26 Apr 2012 23:44:24 -0700, wrote: Call pure function puts start and end in the final two slots. >> >>

Re: Better pure height approximations for beamed rests. (issue 4860043)

2012-04-27 Thread Keith OHara
On Fri, 27 Apr 2012 12:01:04 -0700, m...@apollinemike.com wrote: On 27 avr. 2012, at 19:58, Keith OHara wrote: On Thu, 26 Apr 2012 23:44:24 -0700, wrote: Call pure function puts start and end in the final two slots. You're right that, in the code above, the function gleaned from (cdr pure

Re: Better pure height approximations for beamed rests. (issue 4860043)

2012-04-27 Thread m...@apollinemike.com
On 27 avr. 2012, at 21:01, m...@apollinemike.com wrote: > > Your right that, in the code above, the function gleaned from (cdr pure) gets > passed (list (car args) start end (cdr args)). I'm not exactly sure what > that signifies, but that's what's going on. When in doubt, I always just use >

Re: Better pure height approximations for beamed rests. (issue 4860043)

2012-04-27 Thread m...@apollinemike.com
On 27 avr. 2012, at 19:58, Keith OHara wrote: > On Fri, 27 Apr 2012 03:02:51 -0700, m...@apollinemike.com > wrote: > >> On 27 avr. 2012, at 09:45, Keith OHara wrote: >> >>> On Thu, 26 Apr 2012 23:44:24 -0700, wrote: >>> lily/beam.cc:1743: Beam::pure_rest_collision_callback (SCM smob, SC

Re: Better pure height approximations for beamed rests. (issue 4860043)

2012-04-27 Thread Keith OHara
On Fri, 27 Apr 2012 03:02:51 -0700, m...@apollinemike.com wrote: On 27 avr. 2012, at 09:45, Keith OHara wrote: On Thu, 26 Apr 2012 23:44:24 -0700, wrote: lily/beam.cc:1743: Beam::pure_rest_collision_callback (SCM smob, SCM prev_offset, You're right - this is an error. Do you want me to

Re: Better pure height approximations for beamed rests. (issue 4860043)

2012-04-27 Thread m...@apollinemike.com
On 27 avr. 2012, at 09:45, Keith OHara wrote: > On Thu, 26 Apr 2012 23:44:24 -0700, wrote: > >> lily/beam.cc:1743: Beam::pure_rest_collision_callback (SCM smob, SCM >> prev_offset, >> >> You're right - this is an error. Do you want me to fix it or are you >> working on a patch into which the f

Re: Better pure height approximations for beamed rests. (issue 4860043)

2012-04-27 Thread Keith OHara
On Thu, 26 Apr 2012 23:44:24 -0700, wrote: lily/beam.cc:1743: Beam::pure_rest_collision_callback (SCM smob, SCM prev_offset, You're right - this is an error. Do you want me to fix it or are you working on a patch into which the fix could be incorporated? I am re-ordering the arguments in th

Re: Better pure height approximations for beamed rests. (issue 4860043)

2012-04-26 Thread mike
http://codereview.appspot.com/4860043/diff/4/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/4860043/diff/4/lily/beam.cc#newcode1743 lily/beam.cc:1743: Beam::pure_rest_collision_callback (SCM smob, SCM prev_offset, On 2012/04/27 06:06:21, Keith wrote: Mike, Based on their

Re: Better pure height approximations for beamed rests. (issue 4860043)

2012-04-26 Thread k-ohara5a5a
http://codereview.appspot.com/4860043/diff/4/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/4860043/diff/4/lily/beam.cc#newcode1743 lily/beam.cc:1743: Beam::pure_rest_collision_callback (SCM smob, SCM prev_offset, Mike, Based on their contents, the arguments appear to be i

Re: Better pure height approximations for beamed rests. (issue 4860043)

2011-08-21 Thread mtsolo
Pushed as 9c319db89ecc46cbf6c9c35e759eba973e412bb0. Cheers, MS http://codereview.appspot.com/4860043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel