Re: Avoid easy warnings with Clang (issue 573270043 by jonas.hahnf...@gmail.com)

On 2019/11/24 17:24:07, lemzwerg wrote: > AFAICT this already works with GCC because it just > returns an error code: [...] OK. This deserves a comment IMHO. Ok, will add a description of the status-quo for GCC. https://codereview.appspot.com/573270043/

Re: Avoid easy warnings with Clang (issue 573270043 by jonas.hahnf...@gmail.com)

AFAICT this already works with GCC because it just returns an error code: [...] OK. This deserves a comment IMHO. https://codereview.appspot.com/573270043/

Re: Avoid easy warnings with Clang (issue 573270043 by jonas.hahnf...@gmail.com)

On 2019/11/24 15:13:56, lemzwerg wrote: Please extend this patch to cover gcc, too. AFAICT this already works with GCC because it just returns an error code: $ gcc -Wnot-there -x c /dev/null gcc: error: unrecognized command line option ‘-Wnot-there’ $ echo $? 1 https://codereview.appspot.com

Re: Avoid easy warnings with Clang (issue 573270043 by jonas.hahnf...@gmail.com)

Please extend this patch to cover gcc, too. https://codereview.appspot.com/573270043/

Avoid easy warnings with Clang (issue 573270043 by jonas.hahnf...@gmail.com)

LGTM https://codereview.appspot.com/573270043/diff/549210045/configure.ac File configure.ac (right): https://codereview.appspot.com/573270043/diff/549210045/configure.ac#newcode212 configure.ac:212: # options. Unfortunately GCC doesn't support this options, so we just s/options/option/ And ple