Re: Allows glissandi to span multiple lines. (issue4564042)

2011-06-24 Thread m...@apollinemike.com
Sorry - this patch is obsolete. The new one is at: http://codereview.appspot.com/4527086 Sorry for not having removed the old one, and yes, please add the new one to the countdown (it has gone through a round of commentary). Cheers, MS On Jun 24, 2011, at 4:28 PM, percival.music...@gmail.com

Re: Allows glissandi to span multiple lines. (issue4564042)

2011-06-24 Thread percival . music . ca
On 2011/05/30 07:38:19, mike_apollinemike.com wrote: I'm flying to Ireland today & will attempt to crunch this during the flight. This was almost a month ago. Are you sailing to Ireland instead of flying? ;) What's the status of this patch? If you think that draft 2 is correct, then I'll ad

Re: Allows glissandi to span multiple lines. (issue4564042)

2011-05-30 Thread m...@apollinemike.com
On May 30, 2011, at 12:20 AM, k-ohara5...@oco.net wrote: > This fails the "sniff test" because it removes some careful-looking code > no explanation as to how the job of the old code is being done. > > What happens if the line on the next page is does not, in fact, have the > same vertical refere

Re: Allows glissandi to span multiple lines. (issue4564042)

2011-05-29 Thread k-ohara5a5a
This fails the "sniff test" because it removes some careful-looking code no explanation as to how the job of the old code is being done. What happens if the line on the next page is does not, in fact, have the same vertical reference point? \relative c''' { \override Staff . Glissando #'breakabl

Re: Allows glissandi to span multiple lines. (issue4564042)

2011-05-29 Thread mtsolo
On 2011/05/28 19:40:26, Graham Percival wrote: Could we get that example as a regtest? The regtest comparison shows some warnings in rest-polyphonic2.ly in a different place. I don't know if that's significant. Nothing else changed. I ran the regtests and they look squeaky clean. Lemme

Re: Allows glissandi to span multiple lines. (issue4564042)

2011-05-28 Thread Keith OHara
gmail.com> writes: > > The regtest comparison shows some warnings in rest-polyphonic2.ly in a > different place. I don't know if that's significant. It is not. This is the regtest that proves "too-many colliding" rests will be placed consistently, even though the array holding the "too-many"

Re: Allows glissandi to span multiple lines. (issue4564042)

2011-05-28 Thread percival . music . ca
Could we get that example as a regtest? The regtest comparison shows some warnings in rest-polyphonic2.ly in a different place. I don't know if that's significant. Nothing else changed. http://codereview.appspot.com/4564042/ ___ lilypond-devel maili

Re: Allows glissandi to span multiple lines. (issue4564042)

2011-05-28 Thread percival . music . ca
Have you run a regtest comparison? I was doing a routine on this (and your other patch at the same time), and paper-margins-consistency.ly just borked. I'm now also missing my GNUmakefile.in, which is *extremely* suspicious because there's no way that running "make check" should delete that file

Re: Allows glissandi to span multiple lines. (issue4564042)

2011-05-28 Thread Graham Percival
On Sat, May 28, 2011 at 08:22:01AM +, mts...@gmail.com wrote: > Description: > Allows line spanners to span multiple lines. > > Please review this at http://codereview.appspot.com/4564042/ Thanks, added as http://code.google.com/p/lilypond/issues/detail?id=1673 Cheers, - Graham

Allows glissandi to span multiple lines. (issue4564042)

2011-05-28 Thread mtsolo
Reviewers: , Message: Hey all, A colleague of mine is working on a piece where he needs glissandi to span multiple lines. I made this change and it seems to work. Lemme know if you think it may break something else. I'll run regtests today or tomorrow. To test this patch, do: \relative c''