Re: Allows beam collision to be turned off for certain interfaces. (issue4339053)

2011-04-05 Thread m...@apollinemike.com
On Apr 5, 2011, at 4:00 PM, percival.music...@gmail.com wrote: > LGTM, passes regtests. > > > http://codereview.appspot.com/4339053/diff/1/input/regression/beam-collision-off.ly > File input/regression/beam-collision-off.ly (right): > > http://codereview.appspot.com/4339053/diff/1/input/regress

Re: Allows beam collision to be turned off for certain interfaces. (issue4339053)

2011-04-05 Thread percival . music . ca
LGTM, passes regtests. http://codereview.appspot.com/4339053/diff/1/input/regression/beam-collision-off.ly File input/regression/beam-collision-off.ly (right): http://codereview.appspot.com/4339053/diff/1/input/regression/beam-collision-off.ly#newcode8 input/regression/beam-collision-off.ly:8:

Re: Allows beam collision to be turned off for certain interfaces. (issue4339053)

2011-04-05 Thread hanwenn
LGTM http://codereview.appspot.com/4339053/diff/1/lily/beam-collision-engraver.cc File lily/beam-collision-engraver.cc (right): http://codereview.appspot.com/4339053/diff/1/lily/beam-collision-engraver.cc#newcode60 lily/beam-collision-engraver.cc:60: break; you can do for .. if (covered->has

Allows beam collision to be turned off for certain interfaces. (issue4339053)

2011-04-05 Thread mtsolo
Reviewers: , Message: After some discussion on devel, it seems like a suitable thing to do in the beam collision engraver would be to provide an opt-out for beam collision. Irrespective of how the stem thing winds up getting resolved, I think it's a good idea to be able to switch avoidance on an