On 2012/11/16 22:57:29, dak wrote:
On 2012/11/16 22:13:59, benko.pal wrote:
> LGTM in the sense that it won't make things worse; I've tried to
understand
> the code but failed, see below.
I have not actually tried to understand the code. I just added checks
for
existing array elements bef
Reinhold Kainhofer writes:
> On 2012-11-16 23:57, d...@gnu.org wrote:
>> I have not actually tried to understand the code. I just added checks
>> for existing array elements before access until I could no longer make
>> LilyPond segfault or produce programming errors.
>>
>> So this is, indeed, s
On 2012-11-16 23:57, d...@gnu.org wrote:
I have not actually tried to understand the code. I just added checks
for existing array elements before access until I could no longer make
LilyPond segfault or produce programming errors.
So this is, indeed, strictly a patch on the "won't make things w
Reviewers: benko.pal,
Message:
On 2012/11/16 22:13:59, benko.pal wrote:
LGTM in the sense that it won't make things worse; I've tried to
understand the
code but failed, see below.
I have not actually tried to understand the code. I just added checks
for existing array elements before access
LGTM in the sense that it won't make things worse; I've tried to
understand the code but failed, see below.
http://codereview.appspot.com/6810087/diff/2001/lily/simple-spacer.cc
File lily/simple-spacer.cc (right):
http://codereview.appspot.com/6810087/diff/2001/lily/simple-spacer.cc#newcode375
