Re: Adds footnote-footer-padding to the paper bloc. (issue4384046)

2011-04-09 Thread m...@apollinemike.com
On Apr 8, 2011, at 5:27 PM, n.putt...@gmail.com wrote: > LGTM, just needs a regtest. > > > http://codereview.appspot.com/4384046/diff/5001/lily/page-spacing.cc > File lily/page-spacing.cc (right): > > http://codereview.appspot.com/4384046/diff/5001/lily/page-spacing.cc#newcode88 > lily/page-spa

Re: Adds footnote-footer-padding to the paper bloc. (issue4384046)

2011-04-08 Thread n . puttock
LGTM, just needs a regtest. http://codereview.appspot.com/4384046/diff/5001/lily/page-spacing.cc File lily/page-spacing.cc (right): http://codereview.appspot.com/4384046/diff/5001/lily/page-spacing.cc#newcode88 lily/page-spacing.cc:88: return footnote_height (footnote_height to preserve indent

Re: Adds footnote-footer-padding to the paper bloc. (issue4384046)

2011-04-08 Thread m...@apollinemike.com
On Apr 8, 2011, at 3:44 AM, percival.music...@gmail.com wrote: > On 2011/04/08 07:35:06, Graham Percival wrote: >> This patch appears to break partcombine-midi.ly, but since that's a > very new >> part of the regtests, I'm not totally confident that this isn't just a > random >> fluctuation in mid

Re: Adds footnote-footer-padding to the paper bloc. (issue4384046)

2011-04-08 Thread percival . music . ca
On 2011/04/08 07:35:06, Graham Percival wrote: This patch appears to break partcombine-midi.ly, but since that's a very new part of the regtests, I'm not totally confident that this isn't just a random fluctuation in midi2ly. Never mind; I removed your patch, built a new regtest comparison,

Re: Adds footnote-footer-padding to the paper bloc. (issue4384046)

2011-04-08 Thread percival . music . ca
This patch appears to break partcombine-midi.ly, but since that's a very new part of the regtests, I'm not totally confident that this isn't just a random fluctuation in midi2ly. Do you see the same behaviour when running a regtest comparison? This is the first regtest comparison I've done since

Re: Adds footnote-footer-padding to the paper bloc. (issue4384046)

2011-04-07 Thread percival . music . ca
umm. Getting into Canadian politics? added here: http://code.google.com/p/lilypond/issues/detail?id=1599 http://codereview.appspot.com/4384046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-deve

Adds footnote-footer-padding to the paper bloc. (issue4384046)

2011-04-07 Thread mtsolo
Reviewers: , Message: Fixes the problem flagged by Reinhold regarding the spacing between the footer and the footnotes by adding footnote-footer-padding to the paper bloc. Description: Adds footnote-footer-padding to the paper bloc. Please review this at http://codereview.appspot.com/4384046/