Re: Adds epsilon to Bezier range calculations. (issue4820048)

2011-07-27 Thread Han-Wen Nienhuys
That's weird - the overlap looks way more than 1e-10. Are you sure it is taking the correct extent of the number into account? (I am surprised that we do tuplet number/slur collisions at all.) 2011/7/27 m...@apollinemike.com > On Jul 27, 2011, at 10:59 PM, hanw...@gmail.com wrote: > > this jus

Re: Adds epsilon to Bezier range calculations. (issue4820048)

2011-07-27 Thread m...@apollinemike.com
On Jul 27, 2011, at 10:59 PM, hanw...@gmail.com wrote:this just moves the rounding error an epsilon away.can you post an image of the problem you're solvnig ?http://codereview.appspot.com/4820048/With my new patch, the tuplet collision right at the end of the slur is avoided (lily finds a Bezier in

Re: Adds epsilon to Bezier range calculations. (issue4820048)

2011-07-27 Thread hanwenn
this just moves the rounding error an epsilon away. can you post an image of the problem you're solvnig ? http://codereview.appspot.com/4820048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-dev

Re: Adds epsilon to Bezier range calculations. (issue4820048)

2011-07-27 Thread pkx166h
Added as http://code.google.com/p/lilypond/issues/detail?id=1784 Just in case (some people use tracker more than Rietveld or their inbox so this may get more eyes). http://codereview.appspot.com/4820048/ ___ lilypond-devel mailing list lilypond-devel

Re: Adds epsilon to Bezier range calculations. (issue4820048)

2011-07-27 Thread pkx166h
On 2011/07/27 08:37:06, MikeSol wrote: This passes regtests It does indeed :) James http://codereview.appspot.com/4820048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Adds epsilon to Bezier range calculations. (issue4820048)

2011-07-27 Thread mtsolo
Reviewers: , Message: This passes regtests and adds a regtest to show it in action. As I know nothing about rounding error in C++, I'd like others who are more familiar with this to comment on the way I handle it. Cheers, MS Description: Adds epsilon to Bezier range calculations. Please revie