Pushed as commit
71e0343fdf2a1936b07db0a5892155351c72d553
http://codereview.appspot.com/4368049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Looks great. At the moment, there's some huge space between the code
and the example -- but that's due to texi2pdf spacing things out. If I
remove the second example, then the space is right.
(think about ragged-bottom and ragged-last in lilypond)
Please push.
http://codereview.appspot.com/4
Thanks, done.
http://codereview.appspot.com/4368049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/04/07 12:10:14, J_lowe wrote:
Graham, for now the c9landscape size is already included in the reg
test you set
Nope -- it's commented out. Remember that
@c
is a comment line. Please uncomment the c9landscape line, then remove
the c9 line.
Cheers,
- Graham
http://codereview.appspot.c
On 2011/04/06 22:34:54, Graham Percival wrote:
On 2011/04/06 21:47:34, Graham Percival wrote:
> ... no wait, we do! hmm... I'll look into this. It might be a bit
tricky, so
> I'll handle it myself.
Yeah, it was a bit tricky. But done now:
http://git.savannah.gnu.org/gitweb/?p=lilypond.g
Reviewers: Graham Percival,
Message:
On 2011/04/06 21:47:34, Graham Percival wrote:
I don't think we want to add papersize_test.tely to the repository.
...
Could you create a second version of the patch which does not include
paper-test.tely ?
Done.
Description:
Added new Pagesize definitio
On 2011/04/06 21:47:34, Graham Percival wrote:
... no wait, we do! hmm... I'll look into this. It might be a bit
tricky, so
I'll handle it myself.
Yeah, it was a bit tricky. But done now:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=66b49771545a61b591b529330797163ff42e2e8f
I don't think we want to add papersize_test.tely to the repository.
It's very important that we have such a file while evaluating the patch,
but I think it would be better sent as an attachment in an email to
-devel.
We certainly don't want to add it to build/foo, since that would mess up
the com
