Re: Add hihat halfopen glyph to font (issue 4714043)

2011-08-22 Thread janek . lilypond
LGTM! (and sorry for delay) thanks, Janek http://codereview.appspot.com/4714043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add hihat halfopen glyph to font (issue 4714043)

2011-08-16 Thread Carl . D . Sorensen
Thanks Werner. Fixed. http://codereview.appspot.com/4714043/diff/10001/mf/feta-scripts.mf File mf/feta-scripts.mf (right): http://codereview.appspot.com/4714043/diff/10001/mf/feta-scripts.mf#newcode633 mf/feta-scripts.mf:633: height# / 2, height# / 2); On 2011/08/17 05:25:36, lemzwerg wrote:

Re: Add hihat halfopen glyph to font (issue 4714043)

2011-08-16 Thread lemzwerg
LGTM. http://codereview.appspot.com/4714043/diff/10001/mf/feta-scripts.mf File mf/feta-scripts.mf (right): http://codereview.appspot.com/4714043/diff/10001/mf/feta-scripts.mf#newcode633 mf/feta-scripts.mf:633: height# / 2, height# / 2); Vertical align mismatch. http://codereview.appspot.com/47

Re: Add hihat halfopen glyph to font (issue 4714043)

2011-08-16 Thread Carl . D . Sorensen
I've got a new patch set up. I changed the name to halfopenvertical. I think that the halfopen symbol currently in the font is used for french horn, but Gould does use it for hihat. So I decided to just describe the symbol, rather than specify its use. Also, I shortened up the vertical stroke.