This patch is broken, even though it appears to work. feta-noteheads
and feta-flags share the same code-point space, so it's as if the two
were never split.
This patch will be abandoned and closed once I get my new try.
http://codereview.appspot.com/4662055/
___
On Tue, Jun 28, 2011 at 08:29:55AM +, philehol...@googlemail.com wrote:
> http://codereview.appspot.com/4662055/diff/1/mf/GNUmakefile#oldcode19
> mf/GNUmakefile:19: $(call src-wildcard,feta-notehead*[0-9].mf) \
> I'm assuming this is an old line of make, but I think to be correct,
> feta-notehe
Minor comment.
http://codereview.appspot.com/4662055/diff/1/mf/GNUmakefile
File mf/GNUmakefile (left):
http://codereview.appspot.com/4662055/diff/1/mf/GNUmakefile#oldcode19
mf/GNUmakefile:19: $(call src-wildcard,feta-notehead*[0-9].mf) \
I'm assuming this is an old line of make, but I think to
- Original Message -
From:
To: ; ;
Cc: ;
Sent: Saturday, June 25, 2011 7:42 PM
Subject: Re: Add feta-flags to build system (issue4662055)
LGTM - is there any way to get this in a pixel comparator w/ the
previous flags just to be certain that it doesn't cause any problems t
Carl!
Woot! It works! I compiled it twice, and everything looks fine!!
I told you you are a genious, didn't i? :D
Do i understand correctly that a variable is available to all fonts
(fet_beginfont ... fet_endfont) which are in the same mf file - it's so
simple?
So you solved the problem by callin
LGTM - is there any way to get this in a pixel comparator w/ the
previous flags just to be certain that it doesn't cause any problems to
the flags. The last time I reviewed a flag-related patch, I gave it the
green light only to find that I was failing to see some slight but
important variations.
looks decent
http://codereview.appspot.com/4662055/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: Janek Warchol,
Message:
Here is a revision of Janek's patch to separate feta-flags from
feta-noteheads.
I believe that it works properly; I rebuilt the fonts and the flags look
fine.
To test, you will need to do
rm mf/out/* && make
before testing a lilypond file.
Description:
Add
