Re: Add callback factory grob::inherit-parent-property (issue 8726045)

2013-04-18 Thread dak
On 2013/04/17 18:27:05, MikeSol wrote: Hey, I hadn't seen this. I just finished writing an equivalent patch. Yours is better, so keep it. You can use this for the inherit-X-parent-visibility and eliminate the inherit-Y-parent-visibility callback, which is cruft and can be replaced with the

Re: Add callback factory grob::inherit-parent-property (issue 8726045)

2013-04-17 Thread m...@mikesolomon.org
On 17 avr. 2013, at 21:45, d...@gnu.org wrote: > Reviewers: MikeSol, > > Message: > On 2013/04/17 18:27:05, MikeSol wrote: >> Hey, I hadn't seen this. I just finished writing an equivalent patch. > Yours is >> better, so keep it. You can use this for the > inherit-X-parent-visibility and >> eli

Re: Add callback factory grob::inherit-parent-property (issue 8726045)

2013-04-17 Thread dak
Reviewers: MikeSol, Message: On 2013/04/17 18:27:05, MikeSol wrote: Hey, I hadn't seen this. I just finished writing an equivalent patch. Yours is better, so keep it. You can use this for the inherit-X-parent-visibility and eliminate the inherit-Y-parent-visibility callback, which is cruft

Add callback factory grob::inherit-parent-property (issue 8726045)

2013-04-17 Thread mtsolo
Hey, I hadn't seen this. I just finished writing an equivalent patch. Yours is better, so keep it. You can use this for the inherit-X-parent-visibility and eliminate the inherit-Y-parent-visibility callback, which is cruft and can be replaced with the X one. https://codereview.appspot.com/872604