Re: [PATCH] Fix crash when a stencil routine is missing

2009-07-02 Thread Jan Nieuwenhuizen
On wo, 2009-07-01 at 12:37 -0700, Patrick McCarty wrote: > > Does anyone have comments for this patch? > The "catch all" routine is written, but disabled due to the (if #f > ...). Why not, instead of a programmer's switch between crash/warning, do something like see attached? Greetings, Jan.

Re: [PATCH] Fix crash when a stencil routine is missing

2009-07-01 Thread Patrick McCarty
On Fri, Jun 26, 2009 at 1:46 PM, Patrick McCarty wrote: > On Sat, Jun 20, 2009 at 11:55 AM, Patrick McCarty wrote: >> Hello, >> >> I have uploaded a patch to Rietveld: >> >> http://codereview.appspot.com/83046/show > > Does anyone have comments for this patch? I will provide some more background i

Re: [PATCH] Fix crash when a stencil routine is missing

2009-06-26 Thread Patrick McCarty
On Sat, Jun 20, 2009 at 11:55 AM, Patrick McCarty wrote: > Hello, > > I have uploaded a patch to Rietveld: > > http://codereview.appspot.com/83046/show Does anyone have comments for this patch? Here are some more thoughts I have about this: *** The problematic function that causes the crash is

[PATCH] Fix crash when a stencil routine is missing

2009-06-20 Thread Patrick McCarty
Hello, I have uploaded a patch to Rietveld: http://codereview.appspot.com/83046/show *** The motivation for the patch is this report: http://lists.gnu.org/archive/html/lilypond-user/2009-02/msg00603.html However, since dashed slurs no longer use the "dashed-slur" routine, this particular cras