Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

2008-07-05 Thread Patrick McCarty
On Sat, Jul 5, 2008 at 1:22 PM, Neil Puttock <[EMAIL PROTECTED]> wrote: > 2008/7/5 Graham Percival <[EMAIL PROTECTED]>: > >> Err, I haven't been paying attention. If this is done with an >> \override, then the snippet should definitely be included in >> Trills. Patrick will do this. (note that E

Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

2008-07-05 Thread Neil Puttock
2008/7/5 Graham Percival <[EMAIL PROTECTED]>: > Err, I haven't been paying attention. If this is done with an > \override, then the snippet should definitely be included in > Trills. Patrick will do this. (note that Expressive hasn't > finished the first draft yet) > > If it's a built-in featur

Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

2008-07-05 Thread Graham Percival
On Sat, 5 Jul 2008 20:06:12 +0100 "Neil Puttock" <[EMAIL PROTECTED]> wrote: > Graham, now that I've committed this fix, do you think it's necessary > to document being able to force accidentals for pitched trills? I > suppose a snippet would suffice, but I was wondering whether it's > important en

Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

2008-07-05 Thread Neil Puttock
2008/7/5 Han-Wen Nienhuys <[EMAIL PROTECTED]>: > please push. Graham, now that I've committed this fix, do you think it's necessary to document being able to force accidentals for pitched trills? I suppose a snippet would suffice, but I was wondering whether it's important enough to be mentioned.

Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

2008-07-04 Thread Han-Wen Nienhuys
On Fri, Jul 4, 2008 at 7:58 PM, Neil Puttock <[EMAIL PROTECTED]> wrote: > 2008/6/30 Han-Wen Nienhuys <[EMAIL PROTECTED]>: > >> you need to issue the bt command, which will print the call interface. >> Something is doing a >> >> NULL->set_property(..) >> >> which is obviously wrong > > Cheers for t

Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

2008-07-04 Thread Neil Puttock
2008/6/30 Han-Wen Nienhuys <[EMAIL PROTECTED]>: > you need to issue the bt command, which will print the call interface. > Something is doing a > > NULL->set_property(..) > > which is obviously wrong Cheers for the hint; I did a backtrace as suggested, and it turned out to be Accidental_engraver

Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

2008-06-30 Thread Han-Wen Nienhuys
On Fri, Jun 27, 2008 at 11:23 PM, Neil Puttock <[EMAIL PROTECTED]> wrote: > Here's the debug info from GDB: > > Program received signal SIGSEGV, Segmentation fault. > Grob::internal_set_value_on_alist (this=0x0, alist=0x60, > sym=0x7f678cc35600, v=0x104) at grob-property.cc:296 > 296 return

Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

2008-06-27 Thread Neil Puttock
2008/6/21 Han-Wen Nienhuys <[EMAIL PROTECTED]>: > On Wed, Jun 18, 2008 at 10:26 PM, Neil Puttock <[EMAIL PROTECTED]> wrote: >> I've tried reading the force-accidental property from the music event, >> then adding it to the trill-span-event list, but it causes a segfault. >> :( > > That's strange;

Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

2008-06-21 Thread Han-Wen Nienhuys
On Wed, Jun 18, 2008 at 10:26 PM, Neil Puttock <[EMAIL PROTECTED]> wrote: > 2008/6/12 Han-Wen Nienhuys <[EMAIL PROTECTED]>: > >> the inefficiency of computing things twice is not that important. I'm >> a bit more concerned with duplication of logic, if there is any. Can >> you fold things togethe

Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

2008-06-18 Thread Neil Puttock
2008/6/12 Han-Wen Nienhuys <[EMAIL PROTECTED]>: > the inefficiency of computing things twice is not that important. I'm > a bit more concerned with duplication of logic, if there is any. Can > you fold things together into a common function? As it stands the only duplication would be the code f

Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

2008-06-11 Thread Han-Wen Nienhuys
On Tue, Jun 10, 2008 at 10:42 PM, Neil Puttock <[EMAIL PROTECTED]> wrote: > Hi everybody, > > Attached is the gist of a patch detailing a fix for Issue 524. Could > someone check it for me or suggest any improvements so I can push with > an updated regtest? > > There are two things which I'm concer

Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

2008-06-11 Thread Han-Wen Nienhuys
On Wed, Jun 11, 2008 at 3:55 AM, Mats Bengtsson <[EMAIL PROTECTED]> wrote: > Neil Puttock wrote: > >> As an aside, while working on this fix, I noticed that the description >> for localKeySignature is ambiguous: it says that the property is reset >> at a bar line. As far as I can tell, it only gets

Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

2008-06-11 Thread Neil Puttock
2008/6/11 Mats Bengtsson <[EMAIL PROTECTED]>: > If you manage to digest all the code related to autoAccidentals, > I'm sure you will sooner or later discover that localKeySignature > indeed is reset every bar line, at least if you have the default > settings for autoAccidentals. Well, I'm stickin

Re: [PATCH] Fix 524 (pitched trill accidental forgetfulness)

2008-06-10 Thread Mats Bengtsson
Neil Puttock wrote: As an aside, while working on this fix, I noticed that the description for localKeySignature is ambiguous: it says that the property is reset at a bar line. As far as I can tell, it only gets reset when there's a new key signature. If you manage to digest all the code rel

[PATCH] Fix 524 (pitched trill accidental forgetfulness)

2008-06-10 Thread Neil Puttock
Hi everybody, Attached is the gist of a patch detailing a fix for Issue 524. Could someone check it for me or suggest any improvements so I can push with an updated regtest? There are two things which I'm concerned about: - it copies some code from accidental-engraver.cc to get the current bar n