Re: [PATCH] Fix #305: Allow dynamics to be positioned independently

2009-10-22 Thread Neil Puttock
2009/10/21 Maximilian Albert : > Hmm, okay. I suppose that in most cases people wouldn't want the > hairpin to point in a different direction anyway. Nonetheless, someone > might request it one day. So would you consider this limitation as a > bug? Not really; I think it's just a feature of the c

Re: [PATCH] Fix #305: Allow dynamics to be positioned independently

2009-10-21 Thread Maximilian Albert
Hi Neil, sorry for the long delay in my follow-up. >> As a user, I would normally not include it since I'm not aware of it and >> would thus think that manual positioning of hairpins simply doesn't >> work (or is buggy). Is there a way to avoid it (e.g., by having >> Lilypond automatically detect

Re: [PATCH] Fix #305: Allow dynamics to be positioned independently

2009-10-16 Thread Neil Puttock
2009/10/13 Maximilian Albert : > Awesome, thanks for your work, Neil! Just one question: Why is it > necessary to explicitly specify the \breakDynamicSpan command? I was just following Han-Wen's suggestion in the bug tracker; it hadn't crossed my mind that it would be useful to have automatic bre

Re: [PATCH] Fix #305: Allow dynamics to be positioned independently

2009-10-12 Thread Werner LEMBERG
>> I've added a general event class, BreakSpanEvent, as the parent >> class of BreakDynamicSpanEvent since I'd eventually like to >> implement commands analogous to \breakDynamicSpan for some of the >> other alignment spanners (e.g., pedals and figured bass). > > Awesome, thanks for your work, Ne

Re: [PATCH] Fix #305: Allow dynamics to be positioned independently

2009-10-12 Thread Maximilian Albert
2009/10/12 Neil Puttock : > Please review this patch here: > > http://codereview.appspot.com/129073/show > > I've added a general event class, BreakSpanEvent, as the parent class > of BreakDynamicSpanEvent since I'd eventually like to implement > commands analogous to \breakDynamicSpan for some of

Re: [PATCH] Fix #305: Allow dynamics to be positioned independently

2009-10-12 Thread Carl Sorensen
On 10/12/09 4:57 PM, "Neil Puttock" wrote: > Hi, > > Please review this patch here: > > http://codereview.appspot.com/129073/show LGTM. Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-

[PATCH] Fix #305: Allow dynamics to be positioned independently

2009-10-12 Thread Neil Puttock
Hi, Please review this patch here: http://codereview.appspot.com/129073/show I've added a general event class, BreakSpanEvent, as the parent class of BreakDynamicSpanEvent since I'd eventually like to implement commands analogous to \breakDynamicSpan for some of the other alignment spanners (e.g