Re: [PATCH]: Doc: NR @knownissue for partCombine + spanners (issue4629073)

2011-06-28 Thread pkx166h
Pushed as 8dec1b16ae6daff5b9a0f9fb806db66cf87bc5bd Thanks. Closing this one. James http://codereview.appspot.com/4629073/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [PATCH]: Doc: NR @knownissue for partCombine + spanners (issue4629073)

2011-06-27 Thread percival . music . ca
still looks good; pushing tomorrow am is fine with me. http://codereview.appspot.com/4629073/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [PATCH]: Doc: NR @knownissue for partCombine + spanners (issue4629073)

2011-06-27 Thread pkx166h
Third Draft. Thanks again Trevor. Hopefully I've corrected everything now. I'll wait until tomorrow A.M. and push it then if no one else has any suggestions. http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely

Re: [PATCH]: Doc: NR @knownissue for partCombine + spanners (issue4629073)

2011-06-26 Thread tdanielsmusic
A few more nitpicking typos - some I missed first time through, some you missed when dealing with my earlier comments :) I'm happy for you to push after fixing these. Thanks! Trevor http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simultaneous.itely File Documentation/n

Re: [PATCH]: Doc: NR @knownissue for partCombine + spanners (issue4629073)

2011-06-26 Thread percival . music . ca
looks fine. http://codereview.appspot.com/4629073/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [PATCH]: Doc: NR @knownissue for partCombine + spanners (issue4629073)

2011-06-26 Thread pkx166h
Second Draft - Thanks for the comments Trevor http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely#newcode775 Document

Re: [PATCH]: Doc: NR @knownissue for partCombine + spanners (issue4629073)

2011-06-26 Thread tdanielsmusic
LGTM apart from some editorial nitpicks noted. Trevor http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely#newcode775

[PATCH]: Doc: NR @knownissue for partCombine + spanners (issue4629073)

2011-06-25 Thread pkx166h
Reviewers: , Message: To address http://code.google.com/p/lilypond/issues/detail?id=1643 I realise this is slightly more than the above issue asks for :) but I hope you like the edits and it improves this section. I certainly learnt some 'stuff'. James Description: Doc: NR @knownissue for p