Re: * Use scm_to_int64/from_int64 for Rational/SCM conversions.

2008-09-24 Thread Han-Wen Nienhuys
On Wed, Sep 24, 2008 at 7:42 PM, Neil Puttock <[EMAIL PROTECTED]> wrote: > 2008/9/21 <[EMAIL PROTECTED]>: > >> http://codereview.appspot.com/5889/diff/1/6 >> File lily/moment.cc (right): >> >> http://codereview.appspot.com/5889/diff/1/6#newcode134 >> Line 134: { >> If you want to be paranoid, you

Re: * Use scm_to_int64/from_int64 for Rational/SCM conversions.

2008-09-24 Thread Neil Puttock
2008/9/21 <[EMAIL PROTECTED]>: > http://codereview.appspot.com/5889/diff/1/6 > File lily/moment.cc (right): > > http://codereview.appspot.com/5889/diff/1/6#newcode134 > Line 134: { > If you want to be paranoid, you could check that the most significant > bit is 1 here. That would imply a negativ

* Use scm_to_int64/from_int64 for Rational/SCM conversions.

2008-09-21 Thread hanwenn
Reviewers: Neil Puttock, Message: LGTM - this is what I meant. http://codereview.appspot.com/5889/diff/1/6 File lily/moment.cc (right): http://codereview.appspot.com/5889/diff/1/6#newcode134 Line 134: { If you want to be paranoid, you could check that the most significant bit is 1 here. Descr