Thanks for the ping, it's been a long time! Sadly, I haven't used
lilypond for years. I tried to update my patch, but I cannot spend too
much time on it.
I see that my change to engraver.cc is no longer needed, as there is a
check there that was missing back at the time. The change to
engraver-sche
Reviewers: dak, c_sorensen_byu.edu,
Message:
OK, the problem I wanted to address is to have a documented way to
define new grobs. I hoped that moving add-grob-definition to a "public
place" would be a good start. If it's not, sorry for the noise.
Description:
Move add-grob-definition from a sn
OK, I'll use make-engraver in the next revision. I guess I'll need to
strip all Lilypond 2.14 compatibility stuff if this snippet is to be a
part of the Lilypond documentation. I missed scheme engravers because I
was looking for "\consists #" on one line, my bad.
http://codereview.appspot.com/5
Reviewers: ,
Message:
This is also the first use of a scheme engraver in input/regression.
Description:
Add an example implementation of cross-staff stems
Please review this at http://codereview.appspot.com/5882053/
Affected files:
A input/regression/stem-cross-staff-engraver.ly
_
I mean, why is this needed?
\remove "Stem_engraver"
Stems must be fixing the problem somehow.
http://codereview.appspot.com/5623044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
I'm not getting any interesting information:
...
[/usr/local/share/lilypond/2.15.32/ly/context-mods-init.ly]
[/usr/local/share/lilypond/2.15.32/ly/engraver-init.ly]]
[bad.ly]
Interpreting music...
[/usr/local/share/lilypond/2.15.32/fonts/otf/emmentaler-20.otf]
fatal error: failed files: "bad
There are only two calls to scm_throw in Lilypond, and I could not find
out whether it should be added to engraver.cc or engraver-scheme.cc. I
added it to the former so that other callers to
Engraver::internal_make_grob could benefit. I could not figure out how
to catch an exception. Without ca
Since nobody is interested, I'm closing this issue.
http://codereview.appspot.com/5623044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: ,
Message:
I've seen it many times that Lilypond would crash during my experiments
with Scheme code. This time I decided to track it down. It's my first
ever fix to the C++ code in Lilypond, so please check my coding style.
Description:
Fix crash when unknown grob name is passed to
To be honest, there are many things I don't understand. In fact, I
reduced the example to understand it better.
Why is horizontal spacing affected even though the purity affects the
Y-axis only? Why do stems fix the spacing? Why doesn't this cause the
spacing problem:
\override NoteHead #'t
Reviewers: ,
Message:
The example could be much simpler and still show the problem being
addressed by the unpure-pure containers.
Description:
Doc: simplify example for unpure-pure containers
Use of ly:event-property only confuses matters. Squares are never used.
Draw circles unconditionally,
Just let me know which files should be left untouched and I'll submit
the patch without changes to those files.
http://codereview.appspot.com/5622049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypo
Reviewers: ,
Message:
Too bad I only reviewed the "unpure-pure containers" documentation
(issue 2040) after it was committed.
Description:
Typo fixes
Fix unneeded "ll" in "canceled", "canceling" and "labeled". Replace
"and" with "an" in the documentation about unpure-pure containers.
Please r
On 2012/01/18 15:13:47, Neil Puttock wrote:
http://codereview.appspot.com/5540058/diff/3003/Documentation/changes.tely
Done
http://codereview.appspot.com/5540058/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/lis
Reviewers: ,
Message:
The changelog doesn't mention the issue I have to deal with all the
time, namely splitting Flag from Stem. If not that change, I would be
able to use Lilypond 2.14.2 and the development version without
convert-ly on the same sources. It should definitely be mentioned. An
Reviewers: ,
Message:
The description for rallentando only said that it's an Italian word.
Provide better descriptions for ritardando and rallentando, contrast
them to each other and add references in both directions.
Description:
Docs: Explain the difference between ritardando and rallentando
OK, my mistake, I didn't read the comments on top of changes.tely. The
fixed patch is attached as patch set 2.
http://codereview.appspot.com/5540058/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypon
I don't think I can close this. I see gray "Can't Edit" over
"Publish+Mail Comments". I tried adding my gnu.org address as an alias
in gmail but it changed nothing. Sorry for not being able to
participate more in the discussion!
http://codereview.appspot.com/5530043/
_
I totally share your sentiment, but we depend on an external entity
here, which we cannot control. Suppose we go from 2.15.x to 2.17.x and
put the documentation under "v2.17". For some time, Google won't have
the new location in its index, so the search would get nothing. It
would be better to
19 matches
Mail list logo
