Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

New, simpler, patch added On 2011/10/17 18:56:58, Keith wrote: Most of the complexity is due to the repeating cycle facility. First, you might try out that feature, and reconsider whether it is worth the complexity in the code. I tried it for a number of notations from http://musicnotatio

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

On 2011/10/17 05:11:59, Keith wrote: Piers, there are segfaults and infinite loops reported at http://code.google.com/p/lilypond/issues/detail?id=1972 I uploaded a new patch that fixes this issue, and gives a warning about unexpected behaviour when the list is not sorted. When the list is cont

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

regtests now build with --disable-optimising. Everything should be OK by now. http://codereview.appspot.com/4974075/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

On 2011/09/15 22:05:51, Neil Puttock wrote: On 15 September 2011 23:04, wrote: > On 2011/09/15 21:41:27, Neil Puttock wrote: > >> For some reason, your patch fails `make check' on my system. > > Neil, I've just applied this patch - after seeing your note -  to the >

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

On 2011/09/14 22:12:22, Neil Puttock wrote: http://codereview.appspot.com/4974075/diff/8001/input/regression/staff-ledger-positions.ly File input/regression/staff-ledger-positions.ly (right): http://codereview.appspot.com/4974075/diff/8001/input/regression/staff-ledger-positions.ly#newcode4

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

http://codereview.appspot.com/4974075/diff/1/lily/ledger-line-spanner.cc File lily/ledger-line-spanner.cc (right): http://codereview.appspot.com/4974075/diff/1/lily/ledger-line-spanner.cc#newcode362 lily/ledger-line-spanner.cc:362: ledgers.add_stencil (ledger_line); On 2011/09/13 21:28:58, joene

Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

Reviewers: , Message: Please review my contribution to this wonderful project. Maybe still in time for 2.16 :) On the other hand, it changes quite a bit of the way ledger lines are handled, and I'm not sure what your policy for new features just before release is. Piers Description: Add support

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

http://codereview.appspot.com/4974075/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel