7:07, Milimetr88 wrote:
On 2012/04/25 09:57:48, dak wrote:
> This was a _one_-iteration loop. After the change, it is a
_two_-iterations
> loop.
In http://permalink.gmane.org/gmane.comp.gnu.lilypond.devel/46279
Keith asked me
to change that in a separate commit, so I did so. Did he wanted
http://codereview.appspot.com/5908043/diff/1/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/5908043/diff/1/lily/beam.cc#newcode1326
lily/beam.cc:1326: || beam->get_property_data ("direction") ==
ly_symbol2scm ("calculation-in-progress"))
On 2012/04/25 06:29:14, mike7 wrote
Reviewers: Keith, Graham Percival,
http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh
File flower/include/direction.hh (right):
http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh#newcode63
flower/include/direction.hh:63: // huh?
On 2012/04/24 03:32:28
relatively to the staff.
On 2012/04/14 19:12:01, Keith wrote:
On 2012/04/14 13:56:18, Milimetr88 wrote:
> Relative to which element?
"relative to the staff"
Most English speakers think of this construction as an adjective,
describing
'position', so we use the adjective
Reviewers: Keith, Graham Percival, hanwenn,
Message:
These corrections are included in the Patch Set 2.
http://codereview.appspot.com/5975054/diff/1/flower/include/direction.hh
File flower/include/direction.hh (right):
http://codereview.appspot.com/5975054/diff/1/flower/include/direction.hh#ne
I'm sorry for that, but the next bunch of corrections are in a separate
issue: http://codereview.appspot.com/5975054
It seems that following the procedure from
http://lilypond.org/doc/v2.15/Documentation/contributor/commits-and-patches#uploading-a-patch-for-review
does not make git-cl ask for the
#newcode211
lily/accidental-placement.cc:211: * @return A vector of
Accidental_placement_entrys
On 2012/02/13 03:36:27, joeneeman wrote:
On 2012/02/11 12:27:31, Milimetr88 wrote:
> Do you mean @param and @return or the comment to the function? What
comment
> would you propose?
I'm
Reviewers: ,
Message:
This is a continuation of Issue: http://codereview.appspot.com/5651069/
Description:
Corrected style of comments
Please review this at http://codereview.appspot.com/5862052/
Affected files:
M .gitignore
M flower/include/direction.hh
M lily/accidental-placement.cc
http://codereview.appspot.com/5651069/diff/1/lily/accidental-placement.cc
File lily/accidental-placement.cc (right):
http://codereview.appspot.com/5651069/diff/1/lily/accidental-placement.cc#newcode211
lily/accidental-placement.cc:211: * @return A vector of
Accidental_placement_entrys
Do you mea
