http://codereview.appspot.com/5440084/diff/7001/lily/parser.yy
File lily/parser.yy (right):
http://codereview.appspot.com/5440084/diff/7001/lily/parser.yy#newcode432
lily/parser.yy:432: %type list_music
I must *strongly* recommend that the name of either music_list or
list_music be changed. Ev
http://codereview.appspot.com/5489092/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/12/20 16:27:08, Graham Percival wrote:
On Tue, Dec 20, 2011 at 02:52:34AM +, mailto:md5i.m...@gmail.com
wrote:
>
> In point of fact, I found no additional errors when running make
check.
> Please understand, though, that I have a 32-bit machine. Other
warnings
> may pup up with
On 2011/12/20 14:02:50, Reinhold wrote:
Is anyone here using a 64-bit OS? There are ~150 compiler warnings
when
compiling lilypond currently (see bug 1890), so -Werror can't be
enabled on
64-bit systems.
Yes, this does not surprise me. I wish I had a 64-bit system, but I'm
not due for an u
http://codereview.appspot.com/5489092/diff/1/lily/parser.yy
File lily/parser.yy (right):
http://codereview.appspot.com/5489092/diff/1/lily/parser.yy#newcode36
lily/parser.yy:36: /* Define to get rid of conversion warning, int ->
int16_t. This has
On 2011/12/20 08:32:27, dak wrote:
I think the
Reviewers: ,
Message:
A set of changes to allow lilypond to be built with -Werror using gcc
4.6.2 on i386. I don't know if these changes are desirable, but I am
submitting them in the hopes that they may be useful.
Description:
Changes to allow compiling with -Werror using gcc 4.6.2 on i386.
P
http://codereview.appspot.com/5489092/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/12/20 01:54:29, Graham Percival wrote:
You'll probably find a ton of more errors when running 'make check' --
apparently that compiles some stuff in flower/ that isn't compiled
during a
normal make.
In point of fact, I found no additional errors when running make check.
Please unders
http://codereview.appspot.com/5489092/diff/1/lily/beaming-pattern.cc
File lily/beaming-pattern.cc (right):
http://codereview.appspot.com/5489092/diff/1/lily/beaming-pattern.cc#newcode187
lily/beaming-pattern.cc:187: I64 count = 1; //default -- 1 base moments
in a beam
On 2011/12/20 01:54:29, Gr
http://codereview.appspot.com/5371050/diff/1/lily/grob.cc
File lily/grob.cc (right):
http://codereview.appspot.com/5371050/diff/1/lily/grob.cc#newcode536
lily/grob.cc:536: c = c->dim_cache_[a].parent_;
On 2011/11/10 16:41:54, joeneeman wrote:
After this loop, balance will be 0, right? So the ne
On 2011/05/11 23:12:08, Keith wrote:
http://codereview.appspot.com/4520050/diff/9001/flower/include/pqueue.hh#newcode110
flower/include/pqueue.hh:110: void del (vsize i)
Rather than change the 'flower' library to support deletion from the
heap, I
suggest we continue to use the ignore_ flag on
Small variable nit upon rereading this patch. No change in semantics.
http://codereview.appspot.com/4520050/diff/1/flower/include/pqueue.hh
File flower/include/pqueue.hh (right):
http://codereview.appspot.com/4520050/diff/1/flower/include/pqueue.hh#newcode121
flower/include/pqueue.hh:121: vsiz
12 matches
Mail list logo
