GSoC idea: Frescobaldi extension (issue 571690043 by m...@ursliska.de)

2020-02-19 Thread mail
Reviewers: , Message: This is not as uncontroversial as removing an entire section. However, assuming the tests pass I may consider not waiting for the whole countdown process, if GNU should be selected for the GSoC program. (In that case I'd assume people will mainly look at the GSoC page at the

Remove LO extension from GSoC ideas list (issue 569380043 by m...@ursliska.de)

2020-02-19 Thread mail
Reviewers: , Message: Removing this suggestion from the GSoC page is uncontroversial, I will push after successful tests. Description: Remove LO extension from GSoC ideas list Please review this at https://codereview.appspot.com/569380043/ Affected files (+0, -27 lines): M Documentation/inclu

Move Guile-style modules from scm to scm-modules (issue 567140045 by m...@ursliska.de)

2020-01-29 Thread mail
Reviewers: , Message: Unfortunately I haven't set up a build system on my new computer yet, so this patch is not tested locally at all, so I'm humbly waiting for the automated tests to succeed or fail ... Description: Move Guile-style modules from scm to scm-modules As an initial step towards a

Re: Don't wrap EventChord around rhythmic events by default. (issue 5440084)

2012-01-20 Thread md5i . mail
http://codereview.appspot.com/5440084/diff/7001/lily/parser.yy File lily/parser.yy (right): http://codereview.appspot.com/5440084/diff/7001/lily/parser.yy#newcode432 lily/parser.yy:432: %type list_music I must *strongly* recommend that the name of either music_list or list_music be changed. Ev

Re: Changes to allow compiling with -Werror using gcc 4.6.2 on i386. (issue 5489092)

2011-12-20 Thread md5i . mail
http://codereview.appspot.com/5489092/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Changes to allow compiling with -Werror using gcc 4.6.2 on i386. (issue 5489092)

2011-12-20 Thread md5i . mail
On 2011/12/20 16:27:08, Graham Percival wrote: On Tue, Dec 20, 2011 at 02:52:34AM +, mailto:md5i.m...@gmail.com wrote: > > In point of fact, I found no additional errors when running make check. > Please understand, though, that I have a 32-bit machine. Other warnings > may pup up with

Re: Changes to allow compiling with -Werror using gcc 4.6.2 on i386. (issue 5489092)

2011-12-20 Thread md5i . mail
On 2011/12/20 14:02:50, Reinhold wrote: Is anyone here using a 64-bit OS? There are ~150 compiler warnings when compiling lilypond currently (see bug 1890), so -Werror can't be enabled on 64-bit systems. Yes, this does not surprise me. I wish I had a 64-bit system, but I'm not due for an u

Re: Changes to allow compiling with -Werror using gcc 4.6.2 on i386. (issue 5489092)

2011-12-20 Thread md5i . mail
http://codereview.appspot.com/5489092/diff/1/lily/parser.yy File lily/parser.yy (right): http://codereview.appspot.com/5489092/diff/1/lily/parser.yy#newcode36 lily/parser.yy:36: /* Define to get rid of conversion warning, int -> int16_t. This has On 2011/12/20 08:32:27, dak wrote: I think the

Changes to allow compiling with -Werror using gcc 4.6.2 on i386. (issue 5489092)

2011-12-20 Thread md5i . mail
Reviewers: , Message: A set of changes to allow lilypond to be built with -Werror using gcc 4.6.2 on i386. I don't know if these changes are desirable, but I am submitting them in the hopes that they may be useful. Description: Changes to allow compiling with -Werror using gcc 4.6.2 on i386. P

Re: Changes to allow compiling with -Werror using gcc 4.6.2 on i386. (issue 5489092)

2011-12-19 Thread md5i . mail
http://codereview.appspot.com/5489092/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Changes to allow compiling with -Werror using gcc 4.6.2 on i386. (issue 5489092)

2011-12-19 Thread md5i . mail
On 2011/12/20 01:54:29, Graham Percival wrote: You'll probably find a ton of more errors when running 'make check' -- apparently that compiles some stuff in flower/ that isn't compiled during a normal make. In point of fact, I found no additional errors when running make check. Please unders

Re: Changes to allow compiling with -Werror using gcc 4.6.2 on i386. (issue 5489092)

2011-12-19 Thread md5i . mail
http://codereview.appspot.com/5489092/diff/1/lily/beaming-pattern.cc File lily/beaming-pattern.cc (right): http://codereview.appspot.com/5489092/diff/1/lily/beaming-pattern.cc#newcode187 lily/beaming-pattern.cc:187: I64 count = 1; //default -- 1 base moments in a beam On 2011/12/20 01:54:29, Gr

Re: grob.cc: rewrite O(n^2) algorithm in Grob::common_refpoint algorithm to O(n) (issue 5371050)

2011-11-10 Thread md5i . mail
http://codereview.appspot.com/5371050/diff/1/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/5371050/diff/1/lily/grob.cc#newcode536 lily/grob.cc:536: c = c->dim_cache_[a].parent_; On 2011/11/10 16:41:54, joeneeman wrote: After this loop, balance will be 0, right? So the ne

Re: MIDI: intelligently combine overlapping notes. (issue4520050)

2011-05-11 Thread md5i . mail
On 2011/05/11 23:12:08, Keith wrote: http://codereview.appspot.com/4520050/diff/9001/flower/include/pqueue.hh#newcode110 flower/include/pqueue.hh:110: void del (vsize i) Rather than change the 'flower' library to support deletion from the heap, I suggest we continue to use the ignore_ flag on

MIDI: intelligently combine overlapping notes. (issue4520050)

2011-05-11 Thread md5i . mail
Small variable nit upon rereading this patch. No change in semantics. http://codereview.appspot.com/4520050/diff/1/flower/include/pqueue.hh File flower/include/pqueue.hh (right): http://codereview.appspot.com/4520050/diff/1/flower/include/pqueue.hh#newcode121 flower/include/pqueue.hh:121: vsiz