doc: Update section on "commit access" (issue 566930043 by jonas.hahnf...@gmail.com)

LGTM https://codereview.appspot.com/566930043/diff/581200043/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right): https://codereview.appspot.com/566930043/diff/581200043/Documentation/contributor/source-code.itexi#newcode2196 Documentation/contri

Re: Issue 5584: Rehabilitate regtest workflow (issue 571030043 by nine.fierce.ball...@gmail.com)

LGTM, thanks! https://codereview.appspot.com/571030043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 5578: Add a button to flip between old and new regtest images (issue 566920043 by nine.fierce.ball...@gmail.com)

Very nice, thanks! https://codereview.appspot.com/566920043/diff/581180043/scripts/build/output-distance.py File scripts/build/output-distance.py (right): https://codereview.appspot.com/566920043/diff/581180043/scripts/build/output-distance.py#newcode1030 scripts/build/output-distance.py:1030:

Re: Issue 5576: make output-distance less verbose by default (issue 563120043 by nine.fierce.ball...@gmail.com)

LGTM, thanks! https://codereview.appspot.com/563120043/diff/575170043/GNUmakefile.in File GNUmakefile.in (right): https://codereview.appspot.com/563120043/diff/575170043/GNUmakefile.in#newcode349 GNUmakefile.in:349: $(buildscript-dir)/output-distance $(if $(VERBOSE),-v) --local-datadir --create

Re: Issue 5572: Compile modified C++ files automatically before testing (issue 553080043 by nine.fierce.ball...@gmail.com)

Without testing yet, this looks very nice, thanks! https://codereview.appspot.com/553080043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Check additional names for guile-config (issue 554890043 by jonas.hahnf...@gmail.com)

LGTM, thanks https://codereview.appspot.com/554890043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 5571: streamline cat | sed | sed (issue 551070043 by nine.fierce.ball...@gmail.com)

LGTM, thanks. https://codereview.appspot.com/551070043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Drop requirement for python-devel (issue 566870043 by jonas.hahnf...@gmail.com)

LGTM, thanks. The file `python/midi.c` was rewritten in Python almost three years ago, see commit d8677d345. https://codereview.appspot.com/566870043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypo

Re: Issue 5568: make build output terse by default (issue 557080043 by nine.fierce.ball...@gmail.com)

> What about using `$$@` (or something like that to delay expansion) in > the definition of `ly_progress` and omitting `Making` as an argument, > too? This would give > > $(call ly_progress,) Too rigid. [...] Ok. https://codereview.appspot.com/557080043/ ___

Re: Issue 5568: make build output terse by default (issue 557080043 by nine.fierce.ball...@gmail.com)

We are getting nearer, thanks :-) The next thing I notice is that `ly_progress` is (always?) called as $(call ly_progress,Making,$@,) What about using `$$@` (or something like that to delay expansion) in the definition of `ly_progress` and omitting `Making` as an argument, too? This would gi

Re: Issue 5568: make build output terse by default (issue 557080043 by nine.fierce.ball...@gmail.com)

It should be the build directory. If you know how to achieve it simply, I'll run a search and replace. What about doing $(subst $configure-builddir,,$(abspath ...)) to strip off the builddir prefix? This is untested, however https://codereview.appspot.com/557080043/

Re: Issue 5568: make build output terse by default (issue 557080043 by nine.fierce.ball...@gmail.com)

Thanks for your efforts. Some comments. * What about using the automake format, for example CC foo.o CCLD bar FLEX baz.c See the automake info manual, `Silencing Make', for more. In particular I think that the `Making ' string can be completely omitted. * I can imagin

Re: Issue 5565: simplify python-related makefiles (issue 581080044 by nine.fierce.ball...@gmail.com)

LGTM. https://codereview.appspot.com/581080044/diff/578940043/stepmake/stepmake/python-module-rules.make File stepmake/stepmake/python-module-rules.make (right): https://codereview.appspot.com/581080044/diff/578940043/stepmake/stepmake/python-module-rules.make#newcode1 stepmake/stepmake/python-

make edges of brackets dashable (issue 581060043 by lilyp...@maltemeyn.de)

LGTM, thanks https://codereview.appspot.com/581060043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Remove spurious '% begin verbatim' in Documentation/snippets/new (issue 583000043 by d...@gnu.org)

LGTM, too. No need to add any further formatting right now. After finishing my indexing stuff I will do a second sweep to format all snippets (used in the manual). [And it can be directly added to staging IMHO.] https://codereview.appspot.com/58343/ ___

Remove old make-countdown-announcement.sh (issue 559050043 by jonas.hahnf...@gmail.com)

LGTM, thanks! https://codereview.appspot.com/559050043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Improve generated documentation. (issue 573000044 by lemzw...@googlemail.com)

On 2019/08/28 19:13:14, lemzwerg wrote: Update commit message Oh, this didn't work. So here comes the addendum. Also emit `@vindex' entries as slanted; explain this in `notation.tely'. https://codereview.appspot.com/57344/ ___ lilypond-devel m

Re: Fix relocate-preamble.py bug (issue 560840043 by knup...@gmail.com)

LGTM, thanks! https://codereview.appspot.com/560840043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel