Patch description in the issue tracker has been updated.
https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc
File lily/vowel-transition.cc (right):
https://codereview.appspot.com/565750043/diff/569570043/lily/vowel-transition.cc#newcode37
lily/vowel-transition.cc:37:
Revisions following review
https://codereview.appspot.com/565750043/diff/553710043/Documentation/notation/vocal.itely
File Documentation/notation/vocal.itely (right):
https://codereview.appspot.com/565750043/diff/553710043/Documentation/notation/vocal.itely#newcode894
Documentation/notation/voca
https://codereview.appspot.com/565750043/diff/557620047/scm/define-music-types.scm
File scm/define-music-types.scm (right):
https://codereview.appspot.com/565750043/diff/557620047/scm/define-music-types.scm#newcode685
scm/define-music-types.scm:685: . ((description . "A transition between
lyric
On 2020/03/12 12:06:06, davidsg wrote:
> Rename to vowel-transition-event
Trying again with the name 'vowel transition' (sustained consonants are
mentioned explicitly in the docs). Perhaps this is an OK compromise?
Updated docs accordingly and added a couple of regtests, including one
documen
On 2020/03/11 02:30:04, Dan Eble wrote:
> How about calling it a gradual-vowel-change-event? Come
> to think of it, is this only for vowels, or would it be appropriate to
use it
> for, say, sh -> ss?
Gould talks specifically about vowels, but I don't see any reason why it
shouldn't apply to sh->s
On 2020/03/11 00:32:26, davidsg wrote:
> Removed transition-engraver.cc
hyphen-engraver now also listens for transition-events, and makes
transitions or hyphens based on event class.
Also changed a couple of mentions of line to arrow in regtests.
https://codereview.appspot.com/565750043/
On 2020/03/10 09:59:29, davidsg wrote:
> Revision following review
Removed -> as special syntax, and uses instead the command
\vowelTransition.
Transitions are still separated from hyphens, which leaves
transition-engraver _almost_ a duplicate of hyphen-engraver. As
transitions are printed wi
On 2020/03/08 15:21:22, hanwenn wrote:
> I think it would be better to do this as something that doesn't
require special
> syntax at first, ie. some identifier.
>
One of my motivations for introducing '->' is that it keeps the lyrics
clean and easy to read. Music that uses vowel transitions can
Reviewers: ,
Message:
I've been working on this feature I would like to propose for LilyPond,
and I wonder how I should proceed (request feedback on users group,
discussion here, or something else?). I'm aware of being very much a
beginner here, but I'm tentatively posting this hoping for feedback
Reviewers: ,
Message:
It isn't clear to me how a dimension is different from a normal number,
but the current doc string seems to be incorrect all the same.
Description:
Doc: Corrected doc string for ly:dimension?
ly:dimension? is a predicate - it does not return a number.
Please review this at
Reviewers: ,
Message:
Doc: Added documentation for fill-line line-width
Added short descriptions and examples to Notation Reference.
Suggestions for additions to documentation following this thread on
lilypond-user:
https://lists.gnu.org/archive/html/lilypond-user/2020-01/msg00081.html
Descrip
11 matches
Mail list logo
