The latest patch looks to me to be a proper fix for issue 800.
http://codereview.appspot.com/150067
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
I've uploaded a patch that reverts the "fix" for issue 800, as it
reintroduced the neverending-extender bug. I also added some comments in
the code as requested.
http://codereview.appspot.com/150067
___
lilypond-devel mailing list
lilypond-devel@gnu.o
On 2009/11/10 20:00:00, joeneeman wrote:
http://codereview.appspot.com/150067/diff/2003/3005#newcode113
lily/extender-engraver.cc:113: if (!melisma_busy (voice) &&
!current_lyric_is_skip_ && lyric_acknowledged_)
Could you please add a sentence or two explaining why this test is
here?
Also, ple
Third time's a charm, hopefully. Patch Set 3, which has just been
uploaded, fixes both 786 and 800 without adversely affecting any
regression tests.
(I spoke too soon about potentially uncovering an underlying bug - all
of the bugs were mine)
http://codereview.appspot.com/150067
__
Oops - comment for the 2nd patch set should be "Fixed hyphens..."
Not sure what to do about issue 800 - it might be a bug in some other
portion of the code that my earlier patch uncovered.
http://codereview.appspot.com/150067
___
lilypond-devel maili
Reviewers: ,
Message:
This patch fixes 786 (and 800, which I think should be labeled a dupe).
No regression tests were adversely affected, but there could possibly be
some issues with creating "empty" LyricText objects.
Description:
Fixes issue 786, "Extenders in lyrics stop prematurely if a si
