Re: 100+ warnings and some cosmetics along the way (issue1724041)

2010-06-18 Thread Pap Lôrinc
s it too old? It's the latest ImageMagick for Ubuntu. Any ideas? Lőrinc From: Carl Sorensen To: Pap Lôrinc ; Graham Percival ; "carl.d.soren...@gmail.com" ; Han-Wen Nienhuys ; "lilypond-devel@gnu.org" ; "re...@codereview.appspo

Re: 100+ warnings and some cosmetics along the way (issue1724041)

2010-06-18 Thread Pap Lôrinc
> > - I just did (make check?), it fails (I guess, I'm not sure what to look for). > This is absolutely critical for any large-scale code change. - I have checked out a clean clone of lily and after running ./autogen.sh make all make check (and importing it into Eclipse which doesn't change

Re: 100+ warnings and some cosmetics along the way (issue1724041)

2010-06-17 Thread Pap Lôrinc
http://codereview.appspot.com/1724041/show> > * can you split this up by type of change? ie. one commit doing cosmetics of comments, one changing inline functions, one for casts etc. This makes reviewing easier: a commit touching only comments can be approved with much less scrutiny than one w

PATCH: 100+ warnings and some cosmetics along the way

2010-06-16 Thread Pap Lôrinc
My main concern was fixing the warnings (~150, mostly vsize vs. int), and getting to know the codebase a bit. However, during this procedure I have changed other things also, typedef-ed enums, empty else statements, string repeating, unreferenced parameter names and some random cosmetics