Re: Fixing issue 786 (lyric extenders) again

2010-01-04 Thread Chris Snyder
> Yes, I am top-posting I notice that issue 786 was just marked as critical. I sent the following message to -devel four weeks ago but never received a response. I'd appreciate advice on how to write messages that are more responder-friendly. Chris Snyder wrote: Issue 786, which wa

Fixing issue 786 (lyric extenders) again

2009-12-14 Thread Chris Snyder
Issue 786, which was caused by a patch I submitted back in March, was recently re-opened with another case of an extender being completized too early. Looking at the example, it's easy to spot what's going on. The fix, however, looks to me to be less straightforward. Some background: The origi

CG improvements-collector position (was: [frogs] Frog's Lament)

2009-12-02 Thread Chris Snyder
Graham Percival wrote: Despite my agreements to both paragraphs above, I agree more with the first than the second. Namely, I don't see the point of keeping a list of stuff to add to the docs; that's a recipe for not getting anything done. I think that can depend on a particular person's work

Re: [frogs] Frog's Lament

2009-11-30 Thread Chris Snyder
Valentin Villenave wrote: May I suggest using the existing tracker on bugs.lilynet.net? That would be excellent. Thanks. -Chris ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [frogs] Frog's Lament

2009-11-30 Thread Chris Snyder
Graham Percival wrote: On Thu, Nov 26, 2009 at 11:12:26PM +0100, David Kastrup wrote: We are not talking about explaining concepts to potential contributors in private. We are talking about explanations happening on the developer list. Those can be skimmed off into documentation, without requi

Re: Code formatter

2009-11-13 Thread Chris Snyder
Graham Percival wrote: Whatever. You're giving up. All this time I've spent trying to help you on this was wasted. I'm sure that more experienced developers list are either laughing at me, or shaking their heads sadly... "oh that Graham, he's trying to help the beginners, but he still doesn't

Re: Code formatter

2009-11-13 Thread Chris Snyder
Graham Percival wrote: I know that you're thinking "this is ridiculous", but unless somebody does it, newbies will continue to face this difficulty. This job won't get done by itself. Yes, I do think it's ridiculous. As I understand, you're saying, "go find a tool that makes the code conform t

Re: Code formatter

2009-11-13 Thread Chris Snyder
Graham Percival wrote: 1) running astyle will change lines of code. This makes the history harder to look at... if we want to know who wrote a particular line (say, "there seems to be a bug here; hey Joe, why did you write "if (x = 3)" ?"), then it will appear that *you* were the last person to

Re: Code formatter

2009-11-13 Thread Chris Snyder
Graham Percival wrote: I'm afraid that you won't get many positive responses until you look at the previous discussion about this issue. Again, the main developers have been bitten by people in the past asking many questions, spending hours explaining things to them, but then ultimately giving u

Code formatter

2009-11-12 Thread Chris Snyder
Any takers? -Chris -- Chris Snyder Adoro Music Publishing 1-616-828-4436 x800 http://www.adoromusicpub.com ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Quit [now definitely O/T]

2009-11-12 Thread Chris Snyder
Hi Carl, Thanks for the response. I had one of those "should I want to take that message back?" moments after sending my previous message - I regret the confrontational tone I took at times. Carl Sorensen wrote: Thanks for your contributions. I'm sorry for whatever part I've played in disco

Re: Quit [now definitely O/T]

2009-11-12 Thread Chris Snyder
m still hanging around, however, is a testament more to the quality of the product than to any welcoming atmosphere in the community. (sorry if this message doesn't thread well - I couldn't figure out a good place in the conver

Re: Fixing issue 800 (extender ending early if other voices present)

2009-11-12 Thread Chris Snyder
for > leaving melisma_busy as-is and modifying the call site. I've worked out a solution that seems to work. It's now included in my Rietveld issue for bug 786. -Chris Chris Snyder Adoro Music Publishing 1-616-828-4436 x800 http://www.adoromusicpub.com

Re: Fixing issue 800 (extender ending early if other voices present)

2009-11-11 Thread Chris Snyder
For solution #2, I meant that we can add a check in Extender_engraver::stop_translation_timestep to see if we're in the middle of a note, in addition to the melisma_busy() call (since melisma_busy() doesn't currently do such a check). Chris Snyder Adoro Music Publishing 1

Fixing issue 800 (extender ending early if other voices present)

2009-11-11 Thread Chris Snyder
to address this: 1) Change melisma_busy() to return true if in the middle of a note 2) Alternatively, add the check in Extender_engraver::stop_translation_timestep instead Any guidance on which approach is preferable? Thanks. -- Chris Snyder Adoro Music Publishing 1-616-828-4436 x800 http://w

Re: Span_arpeggio patch

2009-11-10 Thread Chris Snyder
Carl Sorensen wrote: > Way back in January (10 months ago!!!), Chris Snyder was working on a patch > for spanned arpeggios. > > <http://thread.gmane.org/gmane.comp.gnu.lilypond.devel/19682> > > I was asked to shepherd this process, but I have apparently dropped >

Re: Fixes issue 786, "Extenders in lyrics stop prematurely if a single underscore is found."

2009-11-10 Thread Chris Snyder
al.ly? > > I've just run a regression test check and there's a missing hyphen > following "Ky", though the melisma is correct (see attached image). I'm working on it; I fixed the hyphen issue, but now there are a bunch of other lyrics that are spaced wrong. I'l

Re: Issue #786 (lyric extenders completing too early)

2009-09-09 Thread Chris Snyder
note? Or in other words, does the processing of "_" > rely on the code above or not. > > And then there is the Lyric_combine_music_iterator::start_new_syllable > function. would that still work? I thought of another potential problem: Does melisma_busy know about Lyrics cont

Re: Issue #786 (lyric extenders completing too early)

2009-09-09 Thread Chris Snyder
roblem further, but need some guidance as to where I should be looking - should melisma_busy() know about the melisma being extended with underscores in the lyrics, or should an additional check be added in the extender engraver? Thanks, Chris -- Chris Snyder Adoro Music Publishi

Issue #786 (lyric extenders completing too early)

2009-09-09 Thread Chris Snyder
melisma. Since single underscores extend the melisma ("You can define melismata entirely in the lyrics, by entering _ for every extra note that has to be added to the melisma." --LNR 2.1.3), the fix would therefore be to alter the behavior of the melisma_busy function. Thanks, -Chris --

Re: Issue #612 still not fixed

2009-07-04 Thread Chris Snyder
pany (I frequently hear comments about the quality of the engraving, BTW). I'm still intending to follow up on it at some point, but I don't see myself having much available time until August. -Chris -- Chris Snyder Adoro Music Publish

Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space)

2009-03-28 Thread Chris Snyder
On Saturday, March 28, 2009, Joe Neeman wrote: > The problem is that the current support for conditional accidentals is > insufficient if there are multiple accidentals, not all of which are > tied (see bug 612). The reason is that the positions of all the > accidentals can change completely when a

Re: Tied accidentals in chords still taking up space

2009-03-28 Thread Chris Snyder
I've uploaded my patch to Rietveld: http://codereview.appspot.com/28134 (lilypond-devel is cc'd, but the main address on my Google account is different than the one I use here, so I'm not sure if messages it's sending to the list will go through) Joe Neeman wrote: > I think you should do it as so

Re: Tied accidentals in chords still taking up space

2009-03-27 Thread Chris Snyder
Joe Neeman wrote: > On Thu, 2009-03-26 at 10:26 -0400, Chris Snyder wrote: >> Joe Neeman wrote: > It's not necessary to announce every grob (for example, of the three > copies of every breakable grob, only the middle-of-line copy gets > announced). The code for creating th

Re: Tied accidentals in chords still taking up space (was: Issue 415 in lilypond: Hidden accidental of tied note still takes space)

2009-03-26 Thread Chris Snyder
Joe Neeman wrote: > [explanation of spacing code...] > One solution might be the following, which involves modifying only > accidental-placement: make 2 copies of every accidental, one for the > start-of-a-line case and one for the middle-of-a-line case (so the > start-of-a-line accidentals would

[patch] Lyric extenders

2009-03-16 Thread Chris Snyder
Last month I sent a patch to the list dealing with lyric extenders. Since it seems to have gotten lost in the deluge of list traffic, I'm re-sending it, this time posting it on Rietveld: http://codereview.appspot.com/28052 Thanks, -Chris ___ lilypond

2.13.0 source archive

2009-03-03 Thread Chris Snyder
When I browse the download site, the source for 2.13.0 is at http://download.linuxaudio.org/lilypond/sources/v2.13 rather than http://download.linuxaudio.org/lilypond/sources/v2.13/lilypond-2.13.0.tar.gz. Perhaps someone did a "cp lilypond-2.13.0.tar.gz [...]/sources/v2.13 before creating the v2.13

Patch: Fix lyric extenders to end properly

2009-02-24 Thread Chris Snyder
t this patch fixes that instance as well. Thanks. I look forward to any comments. -Chris Snyder >From ae36a3f6e79ce3a15d4e254a8919108b9feed440 Mon Sep 17 00:00:00 2001 From: Chris Snyder Date: Tue, 24 Feb 2009 13:02:17 -0500 Subject: [PATCH] Fix lyric extenders to end properly when there are no

Re: PATCH: Allow setting of arpeggio type for spanned arpeggios

2009-01-23 Thread Chris Snyder
Carl D. Sorensen wrote: > I think if you want to have two spanned arpeggios at the same music moment > with different kinds of arpeggio symbol, you need to use \tweak instead of > \override. > > I wouldn't worry about that for now. That's not my main concern - how would two (or more) spanned arpe

Re: PATCH: Allow setting of arpeggio type for spanned arpeggios

2009-01-23 Thread Chris Snyder
Carl D. Sorensen wrote: > Sounds to me like we have a winner. Chris, will you take on this task? I > think you'll find that the people on -devel are happy to answer coding > questions. Everybody wants more people who can fix/modify LilyPond code, so > we're all happy to help somebody get up to s

Re: PATCH: Allow setting of arpeggio type for spanned arpeggios

2009-01-23 Thread Chris Snyder
(a caveat to the following message: I'm still learning how the LilyPond code is organized - please gently correct me when necessary) Joe Neeman wrote: > My approach can work at the same granularity as \set connectArpeggios. > That is, if the Span_arpeggio_engraver is at the PianoStaff level (which

Re: PATCH: Allow setting of arpeggio type for spanned arpeggios

2009-01-22 Thread Chris Snyder
Carl D. Sorensen wrote: > Can you make a brief regression test that shows why this patch is desirable? > Joe seems to feel like it's unnecessary, because you can set the > span-arpeggio style by setting Score.Arpeggio #'stencil. Well, I put together a regression test, but it's not exactly "brief"

Re: PATCH: Allow setting of arpeggio type for spanned arpeggios

2009-01-21 Thread Chris Snyder
Joe Neeman wrote: > In general, the best approach is to nag us from time to time. If we > don't like the patch, we'll say so; if you get no response, your email > probably just got stuck under a pile of other stuff. I was guessing that that was the case, given its proximity to the release of 2.12

Re: PATCH: Allow setting of arpeggio type for spanned arpeggios

2009-01-21 Thread Chris Snyder
On December 20, 2008, Chris Snyder wrote: > I did realize that the ly_symbol2scm call was not needed. I've > attached a new patch that does not include it. Is there any chance of my patch being accepted into master? What can I do to make the process easier? Thanks. -C

Re: PATCH: Allow setting of arpeggio type for spanned arpeggios

2008-12-20 Thread Chris Snyder
ymbol2scm call was not needed. I've attached a new patch that does not include it. Thanks. -Chris >From 327618ff4ee5e1e275dfb461aa325510e3f21c97 Mon Sep 17 00:00:00 2001 From: Chris Snyder Date: Sat, 20 Dec 2008 15:14:44 -0500 Subject: [PATCH] Altered spanned arpeggios to inherit the stencil

PATCH: Allow setting of arpeggio type for spanned arpeggios

2008-12-18 Thread Chris Snyder
e line of code - quite the result after hours of work), but the functionality seems quite elegant. I've attached the patch according (I hope) to the standards set forth on the LilyPond web site. Feedback (both code- and process-wise) would be greatly appreciated. Thank you. -- Chris Snyd

Slur collisions

2008-08-07 Thread Chris Snyder
During the course of engraving a fairly complex choral piece, I've run into quite a few slur bugs, including 307 (slur collision with tuplet bracket) and 379/586 (slur issues across line breaks). Hoping to be able to fix some of the issues myself and learn about the internals of LilyPond, I st