Re: Renaming baseMoment

2024-10-02 Thread Saul Tobin
baseBeatLength? I don't have a strong opinion either way, but it seems like another natural possibility. On Thu, Oct 3, 2024, 12:44 AM Werner LEMBERG wrote: > > > To follow up the replacement of make-moment by \musicLength [1], I > > think it would make sense to rename baseMoment to beatBaseLeng

Re: Renaming baseMoment

2024-10-02 Thread Werner LEMBERG
> To follow up the replacement of make-moment by \musicLength [1], I > think it would make sense to rename baseMoment to beatBaseLength. > Are there any concerns or other suggestions? Sounds good to me. Werner

Renaming baseMoment

2024-10-02 Thread Dan Eble
To follow up the replacement of make-moment by \musicLength [1], I think it would make sense to rename baseMoment to beatBaseLength. Are there any concerns or other suggestions? -- Dan [1] https://gitlab.com/lilypond/lilypond/-/commit/73ea27187caadc4828d99226f0be64035760fe42

Patches - Countdown to October 4th

2024-10-02 Thread Colin Campbell
Here is the current countdown report. The next countdown will begin on 2024-10-04 A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !2441 Auto_beam_engraver: eliminate beam_start_position_ - Dan Eble     https://gi

New image comparison method

2024-10-02 Thread Luca Fascione
Hi, following up on Werner's query a while back where he was dissatisfied with how the "image diff" metric we use was catching or not problems in test artifacts, I put together a simple python script to address the same problem. Now that I have a script that does something that is of some use (see