Re: Issue 5309, take 2: find_global_context () and find_score_context () (issue 561290043 by nine.fierce.ball...@gmail.com)

https://codereview.appspot.com/561290043/diff/583280043/lily/context.cc File lily/context.cc (right): https://codereview.appspot.com/561290043/diff/583280043/lily/context.cc#newcode116 lily/context.cc:116: if (Context *score = gthis->get_score_context ()) On 2020/01/03 16:18:09, lemzwerg wrote:

PATCHES - Countdown for January 3rd

Hello and Happy New Year! Here is the current patch countdown list. The next countdown will be on January 5th.. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5601 Changes.tely (2.20): \afterGrace com

Re: Issue 5309, take 2: find_global_context () and find_score_context () (issue 561290043 by nine.fierce.ball...@gmail.com)

Reviewers: lemzwerg, Message: On 2020/01/03 16:18:10, lemzwerg wrote: lily/context.cc:116: if (Context *score = gthis->get_score_context ()) Not sure whether compilers warn about the `if (... = ...)` construct. Perhaps the `Context *` prevents it. Otherwise I suggest another level of parenth

Issue 5309, take 2: find_global_context () and find_score_context () (issue 561290043 by nine.fierce.ball...@gmail.com)

LGTM, thanks! https://codereview.appspot.com/561290043/diff/583280043/lily/context.cc File lily/context.cc (right): https://codereview.appspot.com/561290043/diff/583280043/lily/context.cc#newcode116 lily/context.cc:116: if (Context *score = gthis->get_score_context ()) Not sure whether compiler