PATCHES - Countdown for November 20th

2019-11-19 Thread James
Hello, Here is the current patch countdown list. The next countdown will be on November 22nd. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Countdown Push: 5605 implement original () with covarian

Re: What is holding up 2.20 release?

2019-11-19 Thread Adam Good
Just one comment below regarding turkish-makam.ly On Mon, Nov 18, 2019 at 12:16 PM Jonas Hahnfeld wrote: > > > db818c1220 ly: Adding turkish-makam.ly > > looks like a new feature? > Please let me know if I can answer any questions about it or weigh in on thoughts. This one I made and use daily

Re: gub targets + binary packages

2019-11-19 Thread John Mandereau
On Mon, 2019-11-04 at 10:38 +0100, Jonas Hahnfeld wrote: > To be honest I don't know because the binaries don't even start to > execute due to not having the correct libc. So what's the expected > procedure here? There is no libc in the installation tarball, is there > some documentation on what's

Avoid easy warnings with Clang (issue 573270043 by jonas.hahnf...@gmail.com)

2019-11-19 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/573270043/diff/549210045/configure.ac File configure.ac (right): https://codereview.appspot.com/573270043/diff/549210045/configure.ac#newcode212 configure.ac:212: # options. Unfortunately GCC doesn't support this options, so we just s/options/option/ And ple

Re: Issue XXXX: typedef System::rank_type (issue 581270043 by nine.fierce.ball...@gmail.com)

2019-11-19 Thread lemzwerg--- via Discussions on LilyPond development
:-) https://codereview.appspot.com/581270043/

Re: What is holding up 2.20 release?

2019-11-19 Thread John Mandereau
On Mon, 2019-11-18 at 19:29 +0100, Jonas Hahnfeld wrote: > Sure, but does it fix an issue that makes it "critical" enough to add > the new relocation code fairly late in the process? For the discussion that motivated these changes, see https://lists.gnu.org/archive/html/lilypond-devel/2019-02/msg0

Re: Re: What is holding up 2.20 release?

2019-11-19 Thread Mats Bengtsson
On 11/19/19 1:30 AM, Simon Albrecht wrote: 9c0e1363ac Issue #5506: Add tremolo stem support to \cueDuring Looks like a small new "feature", not picked for now. Here I’d say this is not a new feature, but a bug fix, and the mechanisms used for the change are secure enough to pick it. Again,