Re: Replace deprecated functions from string module (issue 566920044 by jonas.hahnf...@gmail.com)

2019-10-23 Thread jonas . hahnfeld
Reviewers: Malte Meyn, Message: On 2019/10/23 21:22:16, Malte Meyn wrote: For someone who doesn’t know python two questions come up: 1. Why do you sometimes use " " and sometimes ' '? AFAIK there is no difference between the two ways of writing a constant string (or not relevant here), so I

Replace deprecated functions from string module (issue 566920044 by jonas.hahnf...@gmail.com)

2019-10-23 Thread lilypond
For someone who doesn’t know python two questions come up: 1. Why do you sometimes use " " and sometimes ' '? 2. Is a space (" " or ' ') the default for the old string.join? Or should you use an empty string ("".join()) instead in some places of the new version? https://codereview.appspot.com/5

PATCHES - Countdown for October 23rd

2019-10-23 Thread James Lowe
Hello, Here is the current patch countdown list. The next countdown will be on October 25th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5580 Replace deprecated functions from string module - Jonas Hahnfe

Re: Replace deprecated functions from string module (issue 566920044 by jonas.hahnf...@gmail.com)

2019-10-23 Thread lilypond
On 2019/10/23 21:22:16, Malte Meyn wrote: 2. Is a space (" " or ' ') the default for the old string.join? Or should you use an empty string ("".join()) instead in some places of the new version? Ok, I found an answer to that question myself. The default is a space indeed. Weird. https://docs.

Re: make test-redo

2019-10-23 Thread Dan Eble
On Oct 14, 2019, at 21:59, Dan Eble wrote: > > On Oct 14, 2019, at 18:27, Carl Sorensen wrote: >> >> What is the defect you are seeing? The last time I tried it, it worked as >> described in the CG. > > I wiped my build directory and ran these commands with master @ fa6c70e39a. > […] I thin

Re: Issue 5584: Rehabilitate regtest workflow (issue 571030043 by nine.fierce.ball...@gmail.com)

2019-10-23 Thread lemzwerg--- via lilypond-devel
LGTM, thanks! https://codereview.appspot.com/571030043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 5583: www_post.py: don't mirror regtest baseline (issue 565170043 by nine.fierce.ball...@gmail.com)

2019-10-23 Thread Dan Eble
> On Oct 23, 2019, at 12:36, David Kastrup wrote: > > "James Lowe" writes: > > Fixes should always be to staging rather than master but I guess that's > what you meant. It depends on just how old the problem is whether one > tries to hotfix it. Baselines created after this commit (a few bac

Re: Issue 5583: www_post.py: don't mirror regtest baseline (issue 565170043 by nine.fierce.ball...@gmail.com)

2019-10-23 Thread David Kastrup
"James Lowe" writes: > Hello, > > On Wed, 23 Oct 2019 06:39:24 -0700, nine.fierce.ball...@gmail.com wrote: > >> Reviewers: , >> >> Description: >> https://sourceforge.net/p/testlilyissues/issues/5583/ >> >> I ran into a problem running "make ... doc" today, where www_post was >> trying unsucces

Re: Issue 5583: www_post.py: don't mirror regtest baseline (issue 565170043 by nine.fierce.ball...@gmail.com)

2019-10-23 Thread David Kastrup
Dan Eble writes: >> On Oct 23, 2019, at 12:36, David Kastrup wrote: >> >> "James Lowe" writes: >> >> Fixes should always be to staging rather than master but I guess that's >> what you meant. It depends on just how old the problem is whether one >> tries to hotfix it. > > Baselines created a

Re: Issue 5583: www_post.py: don't mirror regtest baseline (issue 565170043 by nine.fierce.ball...@gmail.com)

2019-10-23 Thread James Lowe
Hello, On Wed, 23 Oct 2019 06:39:24 -0700, nine.fierce.ball...@gmail.com wrote: > Reviewers: , > > Description: > https://sourceforge.net/p/testlilyissues/issues/5583/ > > I ran into a problem running "make ... doc" today, where www_post was > trying unsuccessfully to mirror a symlink in an out

Issue 5584: Rehabilitate regtest workflow (issue 571030043 by nine.fierce.ball...@gmail.com)

2019-10-23 Thread nine . fierce . ballads
Reviewers: , Description: https://sourceforge.net/p/testlilyissues/issues/5584/ 0. fix repeated test runs for input/regression/midi this is issue 5582 but other changes in this review depend on it 1. fix multiple rules for target collated-files.list 2. don't create the output dir just to r

Issue 5583: www_post.py: don't mirror regtest baseline (issue 565170043 by nine.fierce.ball...@gmail.com)

2019-10-23 Thread nine . fierce . ballads
Reviewers: , Description: https://sourceforge.net/p/testlilyissues/issues/5583/ I ran into a problem running "make ... doc" today, where www_post was trying unsuccessfully to mirror a symlink in an out-test-baseline subdirectory. I looked around for information that would justify mirroring the