On 2019/02/22 21:51:39, Valentin Villenave wrote:
On 2019/02/22 21:00:08, dak wrote:
> You are confusing stencils with stencil expressions. Stencils
satisfy
> ly:stencil? and you can extract their stencil expression (which
usually is a
> pair) with ly:stencil-expr .
Yes, but what we’re de
On 2019/02/22 21:00:08, dak wrote:
You are confusing stencils with stencil expressions. Stencils satisfy
ly:stencil? and you can extract their stencil expression (which
usually is a
pair) with ly:stencil-expr .
Yes, but what we’re dealing with in this function is a stencil
expression, isn’t
Reviewers: dak,
Message:
Thanks David! You make valid points, I just have a couple of doubts
below.
https://codereview.appspot.com/348120043/diff/1/input/regression/script-stencil.ly
File input/regression/script-stencil.ly (right):
https://codereview.appspot.com/348120043/diff/1/input/regressi
https://codereview.appspot.com/348120043/diff/1/lily/script-interface.cc
File lily/script-interface.cc (right):
https://codereview.appspot.com/348120043/diff/1/lily/script-interface.cc#newcode36
lily/script-interface.cc:36: Script_interface::get_glyph_or_stencil
(Grob *me, Direction d)
On 2019/0
Reviewers: ,
Message:
\version "2.21.0"
{
\repeat volta 2 R1
\repeat volta 2 R1
R1
\unset Score.doubleRepeatType
\repeat volta 2 R1
\repeat volta 2 R1
}
Description:
make doubleRepeatType fallback & default the same
The hardcoded fallback was ":|.|:" so \unsetting doubleRepeatType
https://codereview.appspot.com/348120043/diff/1/input/regression/script-stencil.ly
File input/regression/script-stencil.ly (right):
https://codereview.appspot.com/348120043/diff/1/input/regression/script-stencil.ly#newcode31
input/regression/script-stencil.ly:31: #(append! default-script-alist
Hello,
On Fri, 22 Feb 2019 00:04:27 +0100, John Mandereau
wrote:
> David Kastrup wrote:
> > Huh. Maybe the Ubuntu compilation of gcc/g++ disabled some warnings?
> >
> > g++ --verbose
> > Using built-in specs.
> > COLLECT_GCC=g++
> > COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/8/lto-wr
Hello,
Here is the current patch countdown list. The next countdown will be on
February 22nd.
A quick synopsis of all patches currently in the review process can be
found here:
http://philholmes.net/lilypond/allura/
Push:
5418 Add HackLily online editor - Valentin Villenave
https://source
Sorry I sent that previlous email a bit in-haste (I re-use the old email text
and forgot to change it).
The countdown is for Feb 22nd and next countdown is on 25th Feb.
My apologies.
James
On Fri, 22 Feb 2019 08:18:29 + (GMT), "James Lowe"
wrote:
> Hello,
>
> Here is the current patch
