Re: Issue 5415: Fix type-conversion warnings in parser and lexer (issue 348990043 by nine.fierce.ball...@gmail.com)

2018-09-09 Thread nine . fierce . ballads
Reviewers: dak, https://codereview.appspot.com/348990043/diff/1/lily/include/keyword.hh File lily/include/keyword.hh (right): https://codereview.appspot.com/348990043/diff/1/lily/include/keyword.hh#newcode40 lily/include/keyword.hh:40: int lookup (char const *s) const; On 2018/09/09 09:45:53, d

Issue 5415: Fix type-conversion warnings in parser and lexer (issue 348990043 by nine.fierce.ball...@gmail.com)

2018-09-09 Thread dak
https://codereview.appspot.com/348990043/diff/1/lily/includable-lexer.cc File lily/includable-lexer.cc (right): https://codereview.appspot.com/348990043/diff/1/lily/includable-lexer.cc#newcode163 lily/includable-lexer.cc:163: for (size_t i = 0; i < count; ++i) Factoring this out into a separate