Re: Selectively suppress -Wcast-function-type (issue 357770043 by nine.fierce.ball...@gmail.com)

2018-08-15 Thread dak
On 2018/08/15 21:51:46, Dan Eble wrote: On 2018/08/15 16:43:27, dak wrote: > This is more a sort of logic nitpick than of actual relevance given how GCC is > wired, but if we want to be using -Wno-cast-function-type , that's what we > should announce and check for rather than -Wcast-function-

Re: Selectively suppress -Wcast-function-type (issue 357770043 by nine.fierce.ball...@gmail.com)

2018-08-15 Thread nine . fierce . ballads
On 2018/08/15 16:43:27, dak wrote: This is more a sort of logic nitpick than of actual relevance given how GCC is wired, but if we want to be using -Wno-cast-function-type , that's what we should announce and check for rather than -Wcast-function-type . I couldn't figure out any other way t

Re: Selectively suppress -Wcast-function-type (issue 357770043 by nine.fierce.ball...@gmail.com)

2018-08-15 Thread dak
https://codereview.appspot.com/357770043/diff/20001/configure.ac File configure.ac (right): https://codereview.appspot.com/357770043/diff/20001/configure.ac#newcode220 configure.ac:220: CXXFLAGS=-Wcast-function-type This is more a sort of logic nitpick than of actual relevance given how GCC is